PIN setup should only be for tablets |
|||||||||||
Issue descriptionWe should only show PIN setup during OOBE for tablet devices. Currently it is showing for all devices. Need to fix before shipping this feature in M71.
,
Oct 30
,
Oct 30
Yes that sounds good to me
,
Oct 31
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba73cfc8dd99a6336f130ef2c0cd59d8c8e72730 commit ba73cfc8dd99a6336f130ef2c0cd59d8c8e72730 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Oct 31 00:48:05 2018 Chrome OS: suggest user to set up pin in tablet mode only. Bug: 900233 Change-Id: I7af0c470dc7c1d23b5e7fa8fd0db42d42bf9d03d Reviewed-on: https://chromium-review.googlesource.com/c/1309140 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#604082} [modify] https://crrev.com/ba73cfc8dd99a6336f130ef2c0cd59d8c8e72730/chrome/browser/chromeos/login/screens/discover_screen.cc
,
Oct 31
,
Oct 31
Per the M71 Branch Announcement: "Have your change checked into the trunk, and tested by you on either a Canary build or Dev channel release before asking for merge approval." Has this testing taken place? If so, results? If not, please test prior to the merge request. Thanks.
,
Nov 1
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
Mythri, could you quickly test this on canary? Please return issue to me after testing.
,
Nov 1
@alemate, I see the fix is in 72.0.3597.0 which is not there right now. I will verify this issue as soon as the build becomes available.
,
Nov 5
Mythri, 72.0.3601.0 is canary now. Could you check this issue?
,
Nov 6
This is blocking a RBS bug, thus marking as RBS. Can we also clarify behavior here? On a Pixelbook this won't show in clamshell but will as soon as user folds device back to tablet mode? Or does user need to login in tablet mode?
,
Nov 6
Re #11, For tablets & devices in tablet mode: PIN unlock set up was shown during the OOBE. Tested on nocturne, soraka, eve, caroline, cyan. For devices in laptop mode & non-convertibles: PIN unlock was not shown during OOBE. Tested on nocturne, soraka, eve, caroline, careena, cyan, peppy.
,
Nov 7
,
Nov 7
So this one has been fixed and verified per #13 . Waiting for merge approval.
,
Nov 7
Approved for M71 ChromeOS
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34cf0b7b2ab1ba73c28b8fddb0362a730e9e802c commit 34cf0b7b2ab1ba73c28b8fddb0362a730e9e802c Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Nov 07 02:19:45 2018 Chrome OS: suggest user to set up pin in tablet mode only. TBR=alemate@chromium.org (cherry picked from commit ba73cfc8dd99a6336f130ef2c0cd59d8c8e72730) Bug: 900233 Change-Id: I7af0c470dc7c1d23b5e7fa8fd0db42d42bf9d03d Reviewed-on: https://chromium-review.googlesource.com/c/1309140 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604082} Reviewed-on: https://chromium-review.googlesource.com/c/1322110 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#557} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/34cf0b7b2ab1ba73c28b8fddb0362a730e9e802c/chrome/browser/chromeos/login/screens/discover_screen.cc
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34cf0b7b2ab1ba73c28b8fddb0362a730e9e802c Commit: 34cf0b7b2ab1ba73c28b8fddb0362a730e9e802c Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-11-07 02:19:45 +0000 UTC Chrome OS: suggest user to set up pin in tablet mode only. TBR=alemate@chromium.org (cherry picked from commit ba73cfc8dd99a6336f130ef2c0cd59d8c8e72730) Bug: 900233 Change-Id: I7af0c470dc7c1d23b5e7fa8fd0db42d42bf9d03d Reviewed-on: https://chromium-review.googlesource.com/c/1309140 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604082} Reviewed-on: https://chromium-review.googlesource.com/c/1322110 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#557} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by alemate@chromium.org
, Oct 30