New issue
Advanced search Search tips

Issue 900202 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772130



Sign in to add a comment

Parameterize tests using kCompositorTouchAction

Project Member Reported by xidac...@chromium.org, Oct 30

Issue description

We have created this flag for implementing the feature of compositor acking touch start. The feature is now under development, and we should parameterize some tests to make sure that it works with/out this flag.

The tests include:
InputRouterImplTest
InputHandlerProxyTest
TouchActionBrowserTest
TouchActionFilterTest (maybe)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d

commit 12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Nov 01 02:36:24 2018

Parameterize some tests using kCompositorTouchAction

This CL parameterize some tests using this flag. It does 2 things:
1. Move the kCompositorTouchAction flag from content/ to ui/events/blink.
This is because InputHandlerProxy will need to have access to this flag,
and that content/ depends on ui/events/blink.
2. Parameterize necessary tests based on this flag. Tests include:
InputRouterImplTest, TouchActionFilterTest, InputHandlerProxyTest,
TouchActionBrowserTest.

In order to pameterize the InputRouterImplTest, we have to extract a
InputRouterImplTestBase. The reason is that InputRouterImplTest has a
subclass "TouchpadPinchInputRouterImplTest", which is already a
parameterized test depending on another flag.

Bug:  900202 
Change-Id: I07e30739ee86aaf8b1840d6e0dccfc504a16b075
Reviewed-on: https://chromium-review.googlesource.com/c/1307833
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604491}
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/browser/renderer_host/input/touch_action_filter_unittest.cc
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/public/common/content_features.cc
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/public/common/content_features.h
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/content/test/BUILD.gn
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/ui/events/blink/blink_features.cc
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/ui/events/blink/blink_features.h
[modify] https://crrev.com/12592d437d9baa6ab3ec78e7ee48c1a98dff6c7d/ui/events/blink/input_handler_proxy_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment