Favicon shown instead of security indicator |
||||||
Issue descriptionChrome Version: 72.0.3596.0 OS: macOS What steps will reproduce the problem? (1) Open any site (2) Click security indicator What is the expected result? The security indicator doesn't change. Page info is shown. What happens instead? The security indicator is replaced with the site's favicon. Clicking the favicon doesn't to anything. See attached screencast.
,
Oct 30
Currently, when Query in Omnibox is enabled, and the user clicks the Page Info bubble, we unelide and show the full URL by entering user-input-in-progress mode. As a side effect we also show the page favicon when this occurs. It's telling that you thought this was a bug. Emily, thoughts?
,
Oct 30
,
Oct 30
Maybe related to issue 894862 ?
,
Nov 1
Unable to reproduce the issue on reported chrome version #72.0.3596.0 using Mac OS 10.14 by following steps as per comment#0. Observed that on clicking the security indicator did not change and the page info is shown. Attached screencast for reference. @maxwalker: Could you please review attached screencast and let us know if anything is being missed from our end. Thanks.!
,
Nov 2
Thanks for checking! The bug only occurs when the query-in-omnibox flag is enabled (chrome://flags/#enable-query-in-omnibox). Tommy, the behavior that makes this a bug to me is 1) that the favicon switch seems unexpected and unnecessary(?) and 2) that we keep the favicon state when you click out of page info. Then, clicking the favicon again doesn't do anything so it's not possible to go back to page info (see screen recording in #1). Why do we need to switch the indicator at all? Proposal: 1. Keep the security indicator (icon, verbose state or search engine favicon) unchanged in all states 2. Unelide the URL (scheme + subdomains, full url for search queries) when page info is shown 3. Switch back to the elided URL (or search query) when page info is dismissed WDYT?
,
Nov 2
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 5
From my perspective, the Page Info bubble is anchored to the security indicator, since one purpose of Page Info is to explain the meaning security indicator icon and the current page security state. Showing anything besides the security indicator when the Page Info bubble is up seems like a bug. I agree with Max's points about confusion in #7, and especially that the favicon stays after closing the page info bubble (it is not obvious that this is because the URL is still expanded). I think Max's proposed behavior is a good approach. (A lesser concern would be a site that intentionally uses the lock icon as their favicon to get a "more favorable" icon when a user clicks the "i" info icon (for an HTTP site trying to pretend to be an HTTPS site). That scenario is a little contrived though.) This reproduces for me on Chromium 72.0.3599.0 on Linux, so I'm adding all desktop OS labels since this likely affects all of them. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by maxwalker@chromium.org
, Oct 30954 KB
954 KB View Download