Divider padding seems to have no effect in keyboard accessory |
||||||
Issue descriptionAlthough we introduced padding around the dividers, it seems to have no effect. Fix that. (8dp below top divider and 8dp below and above the regular divider) This should have been part of 71 already.
,
Oct 30
Merge rational: Very small, isolated UI change blocking LB.
,
Oct 30
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
Approved for merge to 71, branch 3578.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/468367a0a902941bc45a25eeb17fd1671079c235 commit 468367a0a902941bc45a25eeb17fd1671079c235 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Nov 05 11:36:17 2018 [Android] Add margin to accessory for divider and multi-line labels The padding in divider elements hasn't had any effect which is fixed by using the margin instead which shows the desired spacing. Additionally, the line height wouldn't affect the height of the title label and negate any existing padding which is fixed by using the correct lineSpacingMultiplier. Bug: 856180 , 900178 Change-Id: Ie4e9e1df1081da9fa5dc5e6aeb1bcb578f22d7d0 Reviewed-on: https://chromium-review.googlesource.com/c/1307399 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603951}(cherry picked from commit 9855219e2fa70f37292b258c13e22861d0f85068) Reviewed-on: https://chromium-review.googlesource.com/c/1317626 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#493} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/468367a0a902941bc45a25eeb17fd1671079c235/chrome/android/java/res/layout/password_accessory_sheet_divider.xml [modify] https://crrev.com/468367a0a902941bc45a25eeb17fd1671079c235/chrome/android/java/res/layout/password_accessory_sheet_label.xml [modify] https://crrev.com/468367a0a902941bc45a25eeb17fd1671079c235/chrome/android/java/res/layout/password_accessory_sheet_top_divider.xml
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/468367a0a902941bc45a25eeb17fd1671079c235 Commit: 468367a0a902941bc45a25eeb17fd1671079c235 Author: fhorschig@chromium.org Commiter: fhorschig@chromium.org Date: 2018-11-05 11:36:17 +0000 UTC [Android] Add margin to accessory for divider and multi-line labels The padding in divider elements hasn't had any effect which is fixed by using the margin instead which shows the desired spacing. Additionally, the line height wouldn't affect the height of the title label and negate any existing padding which is fixed by using the correct lineSpacingMultiplier. Bug: 856180 , 900178 Change-Id: Ie4e9e1df1081da9fa5dc5e6aeb1bcb578f22d7d0 Reviewed-on: https://chromium-review.googlesource.com/c/1307399 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603951}(cherry picked from commit 9855219e2fa70f37292b258c13e22861d0f85068) Reviewed-on: https://chromium-review.googlesource.com/c/1317626 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#493} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 30