Regression: Text on 'Add Address' overlay is seen chopped after increasing the minimum font size.
Reported by
sanyam.g...@etouch.net,
Oct 30
|
||
Issue descriptionChrome Version: 72.0.3595.2 (Official Build) 4af8b5a14fa87ad1e81fa9ae20c30f9a8c1494cb-refs/branch-heads/3595@{#4}(32/64 bit) OS: Win(7,8,8.1,10), Mac(10.13.1 , 10.13.6 , 10.14.1) and Linux(14.04 LTS) OS What steps will reproduce the problem? 1.Launch chrome, navigate to chrome://settings/fonts and increase minimum font size to 'Huge' 2.Navigate to 'chrome://settings/autofill' or 'chrome://settings/payments' and click on Add button. 3.Observe the text on the overlay. Actual : Text on 'Add Address' or 'Add card' overlay is seen chopped after increasing the minimum font size to huge. Expected: Text on 'Add Address' or 'Add card' overlay should not be seen chopped after increasing the minimum font size to huge. This is Regression issue seen in M-69, and below is bisect info. Good Build: 69.0.3450.0 (Revision: 564324) Bad Build : 69.0.3451.0 (Revision: 564768) You are probably looking for a change made after 564676 (known good), but no later than 564677 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3ec8c0556c4b6af90db14c365ee0376c72982905..66c801f15e20c5a8399054d7f8d8fc53477c6302 Suspect: https://chromium.googlesource.com/chromium/src/+/66c801f15e20c5a8399054d7f8d8fc53477c6302 @scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: Issue is also seen on Beta build #71.0.3578.20 and Canary build #72.0.3596.0 Thank You..!!
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/328798164e5e8c931329e7056d52c888c79e53eb commit 328798164e5e8c931329e7056d52c888c79e53eb Author: Scott Chen <scottchen@chromium.org> Date: Fri Dec 14 23:17:04 2018 WebUI: fix input labels for large minimum-font-size Originally, cr-input's font-size, height, line-height are all set to 0.625rem, but when the minimum-font setting changes, font-size is forced to not respect "rem". This CL changes the height/line-height styling to be 1em, such that it stays in sync with the label's actual font-size, instead of with rem, since the original intention was for height/line-height to equal the exact font height anyway. Bug: 900135 Change-Id: I5a64114fad5d0b7455c6e577b04c3a26e21fbfba Reviewed-on: https://chromium-review.googlesource.com/c/1376664 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616868} [modify] https://crrev.com/328798164e5e8c931329e7056d52c888c79e53eb/ui/webui/resources/cr_elements/shared_vars_css.html
,
Dec 17
|
||
►
Sign in to add a comment |
||
Comment 1 by scottchen@chromium.org
, Dec 14