Issue metadata
Sign in to add a comment
|
Regression: Unnecessary Zoom in icon stays in omnibox for youtube.com page even after it gets reset from app window.
Reported by
db...@etouch.net,
Oct 30
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3595.2 Revision 4af8b5a14fa87ad1e81fa9ae20c30f9a8c1494cb-refs/branch-heads/3595@{#4}(32/64 bite) OS: Windows(7,8,10), Linux(14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://apps page and right click on Youtube app then select Open as window option. (2) Open youtube.com page in NTP and then launch Youtube app into separate window. (3) Click on wrench menu and click on zoom in icon then press ctrl+O and observe on original window(where youtube.com page opened ) Actual: Unnecessary Zoom in icon stays in omnibox for youtube.com page even after it gets reset. Expected: Zoom icon should not stays in omnibox for youtube.com page even after it gets reset. This is a regression issue, broken in 'M70', below is bisect info: Good Build:70.0.3511.0(Revision: 580407) Bad Build: 70.0.3512.0(Revision: 580755) Chromium bisect info: You are probably looking for a change made after 580417(known good), but no later than 580425(first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/a93d9c56878e80848daed075d8f882072e9e731d..1f682c4f30000c305a005a1303eb4627a48dc32e Suspecting: https://chromium.googlesource.com/chromium/src/+/e70a6109f43e2d171b21666258aad6808685331f @alancutter: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: 1.Issue is not seen on Mac (10.13.1, 10.13.6, 10.14.1) OS. 2.Issue is also seen on Beta build #71.0.3578.20 and Canary build #72.0.3596.0
,
Oct 31
Note: This bug exists for two separate browser windows, no need for the hosted app window.
,
Nov 1
,
Nov 1
,
Nov 8
,
Nov 14
***Mass UI Triage*** Just to update: Still we are able to reproduce the issue on latest canary #72.0.3609.3 on Windows(7,8,8.1,10) and Linux(14.04) OS. @alancutter: Could you please take a look into this issue. Kindly find the attached screen-cast for reference. Thank you.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c58cb2c0ede899a3aa7b7808131044e4db69df0 commit 9c58cb2c0ede899a3aa7b7808131044e4db69df0 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Dec 10 01:16:58 2018 Fix zoom icon persisting in inactive window This CL updates the zoom icon visibility logic to only pay attention to zoom bubbles that are connected to the same browser window the icon is in. Bug: 900134 Change-Id: I7aedb32b450b1b51aed602671fe3b2fb8946960e Reviewed-on: https://chromium-review.googlesource.com/c/1309385 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615025} [modify] https://crrev.com/9c58cb2c0ede899a3aa7b7808131044e4db69df0/chrome/browser/ui/views/page_action/zoom_view.cc [modify] https://crrev.com/9c58cb2c0ede899a3aa7b7808131044e4db69df0/chrome/browser/ui/views/page_action/zoom_view.h [add] https://crrev.com/9c58cb2c0ede899a3aa7b7808131044e4db69df0/chrome/browser/ui/views/page_action/zoom_view_browsertest.cc [modify] https://crrev.com/9c58cb2c0ede899a3aa7b7808131044e4db69df0/chrome/test/BUILD.gn
,
Dec 10
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alancutter@chromium.org
, Oct 31Status: Started (was: Assigned)