New issue
Advanced search Search tips

Issue 900126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

single_process_mash_browser_tests is failing

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 30

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of horo@chromium.org

b2085524-5cd6-47f1-83d6-5b8452a6c0df

Builders failed on: 
- linux-chromeos-dbg: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


Failed tests:

InitiallyMaximized/AcceleratorCommandsPlatformAppFullscreenBrowserTest.ToggleFullscreen/0
InitiallyRestored/AcceleratorCommandsPlatformAppFullscreenBrowserTest.ToggleFullscreen/0

 
Summary: single_process_mash_browser_tests is failing (was: b2085524-5cd6-47f1-83d6-5b8452a6c0df)
Cc: -est...@chromium.org
Owner: est...@chromium.org
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931266246758083184/+/steps/single_process_mash_browser_tests/0/logs/InitiallyMaximized__x2f_AcceleratorCommandsPlatformAppFullscreenBrowserTest.ToggleFullscreen__x2f_0/0

[ RUN      ] InitiallyMaximized/AcceleratorCommandsPlatformAppFullscreenBrowserTest.ToggleFullscreen/0
[21409:21409:1029/225756.644832:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user
[21409:21409:1029/225756.964245:WARNING:easy_unlock_service_regular.cc(611)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
[21409:21409:1029/225756.964357:INFO:easy_unlock_service_regular.cc(163)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices().
[21409:21409:1029/225758.201442:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[21409:21409:1029/225759.658373:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart()
[21409:21409:1029/225759.658482:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued.
[21409:21409:1029/225759.658913:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel.
[21409:21409:1029/225759.659899:INFO:device_sync_service.cc(31)] DeviceSyncService::OnStart()
[21409:21409:1029/225759.660273:INFO:device_sync_service.cc(48)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync.
[21409:21409:1029/225759.661357:INFO:multidevice_setup_service.cc(62)] MultiDeviceSetupService::OnStart()
[21409:21409:1029/225759.661720:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[21409:21409:1029/225759.800911:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service.
[21409:21409:1029/225759.813779:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[21409:21409:1029/225800.186319:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing
[21409:21409:1029/225800.341488:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[21409:21409:1029/225800.474713:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing
[21409:21409:1029/225800.980810:ERROR:remote_text_input_client.cc(158)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged()
[21409:21409:1029/225800.980900:ERROR:remote_text_input_client.cc(115)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const
[21409:21409:1029/225800.980940:ERROR:remote_text_input_client.cc(200)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning()
[21409:21409:1029/225800.981070:ERROR:remote_text_input_client.cc(109)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const
[21409:21409:1029/225800.981114:ERROR:remote_text_input_client.cc(121)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const
[21409:21409:1029/225800.981265:ERROR:remote_text_input_client.cc(176)] Not implemented reached in virtual void RemoteTextInputClient::EnsureCaretNotInRect(const gfx::Rect &)
[21409:21409:1029/225803.999687:ERROR:multi_user_window_manager_stub.cc(54)] Not implemented reached in virtual void MultiUserWindowManagerStub::AddObserver(MultiUserWindowManager::Observer *)
[21409:21409:1029/225804.073575:ERROR:render_widget_host_view_aura.cc(1282)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const
[21409:21409:1029/225804.204679:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing
[21409:21409:1029/225804.675357:ERROR:multi_user_window_manager_stub.cc(54)] Not implemented reached in virtual void MultiUserWindowManagerStub::AddObserver(MultiUserWindowManager::Observer *)
[21409:21409:1029/225804.881212:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing
[21409:21409:1029/225805.644925:ERROR:multi_user_window_manager_stub.cc(58)] Not implemented reached in virtual void MultiUserWindowManagerStub::RemoveObserver(MultiUserWindowManager::Observer *)
[21409:21409:1029/225805.658849:ERROR:multi_user_window_manager_stub.cc(54)] Not implemented reached in virtual void MultiUserWindowManagerStub::AddObserver(MultiUserWindowManager::Observer *)
[21409:21409:1029/225806.075609:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing
../../chrome/browser/ui/ash/accelerator_commands_browsertest.cc:302: Failure
Value of: IsInImmersive(native_app_window->GetNativeWindow())
  Actual: true
Expected: false
Stack trace:
#0 0x000007433abe (/b/s/w/ir/out/Release/browser_tests+0x7433abd)
#1 0x000007456530 (/b/s/w/ir/out/Release/browser_tests+0x745652f)
#2 0x00000745511a (/b/s/w/ir/out/Release/browser_tests+0x7455119)
#3 0x000005465d0a (/b/s/w/ir/out/Release/browser_tests+0x5465d09)
#4 0x00001434223e (/b/s/w/ir/out/Release/browser_tests+0x1434223d)
#5 0x000012e538f0 (/b/s/w/ir/out/Release/browser_tests+0x12e538ef)
#6 0x000012e50abc (/b/s/w/ir/out/Release/browser_tests+0x12e50abb)
#7 0x000006004a5d (/b/s/w/ir/out/Release/browser_tests+0x6004a5c)
#8 0x00000afe461e (/b/s/w/ir/out/Release/browser_tests+0xafe461d)
#9 0x00000c34ce1c (/b/s/w/ir/out/Release/browser_tests+0xc34ce1b)
#10 0x00000afe11f7 (/b/s/w/ir/out/Release/browser_tests+0xafe11f6)
#11 0x00000afeb7f4 (/b/s/w/ir/out/Release/browser_tests+0xafeb7f3)
#12 0x00000afdb080 (/b/s/w/ir/out/Release/browser_tests+0xafdb07f)
#13 0x000011781a66 (/b/s/w/ir/out/Release/browser_tests+0x11781a65)
#14 0x00001a631014 (/b/s/w/ir/out/Release/browser_tests+0x1a631013)
#15 0x00001177c736 (/b/s/w/ir/out/Release/browser_tests+0x1177c735)
#16 0x000014340d3d (/b/s/w/ir/out/Release/browser_tests+0x14340d3c)

[21409:21409:1029/225806.764841:ERROR:multi_user_window_manager_stub.cc(58)] Not implemented reached in virtual void MultiUserWindowManagerStub::RemoveObserver(MultiUserWindowManager::Observer *)
[21409:21409:1029/225807.249016:ERROR:multi_user_window_manager_stub.cc(58)] Not implemented reached in virtual void MultiUserWindowManagerStub::RemoveObserver(MultiUserWindowManager::Observer *)
[21409:21442:1029/225809.085717:WARNING:discardable_shared_memory_manager.cc(409)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[21409:21409:1029/225809.113396:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[21409:21409:1029/225809.113618:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] InitiallyMaximized/AcceleratorCommandsPlatformAppFullscreenBrowserTest.ToggleFullscreen/0, where GetParam() = 3 (13965 ms)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c5ac98f29d3fbac14f73907dbea1ce46b456f38

commit 7c5ac98f29d3fbac14f73907dbea1ce46b456f38
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Oct 30 07:50:42 2018

Revert "Merge two immersive mode window properties."

This reverts commit 1e9af0714f0e6164ff6d3444bee334c4f2d02778.

Reason for revert: Caused single_process_mash_browser_tests failure

Bug:  900126 

Original change's description:
> Merge two immersive mode window properties.
> 
> aura::client::kImmersiveFullscreenKey is folded into
> ash::kImmersiveIsActive
> 
> No bug here currently, but it's confusing to have two different
> properties that are both meant to indicate immersive mode is active.
> 
> Also removed some unnecessary ash:: prefixes from //ash.
> 
> Change-Id: I0c43873fa8f128c3799d32f2c479a1f2caa9a7cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1298493
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603778}

TBR=jamescook@chromium.org,sky@chromium.org,estade@chromium.org,tsepez@chromium.org

Change-Id: I29aae80dffeed4ed8f1609ee02ba3822dae928f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1307314
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603825}
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/wm/immersive_context_ash.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/wm/window_state.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ash/wm/window_state.h
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/chrome/browser/ui/views/frame/immersive_context_mus.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/components/exo/shell_surface_base.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/services/ws/public/mojom/window_manager.mojom
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ui/aura/client/aura_constants.h
[modify] https://crrev.com/7c5ac98f29d3fbac14f73907dbea1ce46b456f38/ui/aura/mus/property_converter.cc

Status: Fixed (was: Available)
fixed by revert

(second try is here: https://chromium-review.googlesource.com/c/chromium/src/+/1307842 )

Sign in to add a comment