New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900124 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VK not work at all for Guest user

Project Member Reported by xiulingw@chromium.org, Oct 30

Issue description

Version 72.0.3591.0(Official build) unknown(32-bit)
Platform 11195.0.0(official build) dev-channel kevin test
Firmware Google_Kevin.8785.264.0
Google_Input_Tools_Version:72.0.20181029.219244077


REPRO STEPS:
1.Browse as Guest.
2.Turn over the laptop (or enable #virtual keyboard) to make VK pops up .
3.Touch VK.


Actual result: 
VK does not work at all.

 
Also repro on latest M71 version:  Google_Input_Tools_Version:71.0.20181030.218828658.
Please update your Chrome Book to R71-11151.16.0
Owner: shuchen@chromium.org
Hi Shuchen,
I already verify in latest M72, IMF doesn't fire onFocus event in guest mode.
Whatever I listen on chrome.input.ime.onFocus or chrome.inputmethodPrivate.onFocus.


Labels: rel
I confirm it's not repro on M71.
Tried no repro on M71.
Not repro on 
Version 71.0.3578.27(platform 11151.16.0-18.10.29) dev-channel kevin test
Google_Input_Tools_Version:71.0.20181030.218828658.
Status: Started (was: Assigned)
Confirmed this is a regression caused by the http://crrev.com/c/1288350.

Working on the fix.

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f0b419df243400f954e11b649f4862a1e0ff367

commit 2f0b419df243400f954e11b649f4862a1e0ff367
Author: Shu Chen <shuchen@google.com>
Date: Mon Nov 05 09:00:58 2018

Fix the regression caused by http://crrev.com/c/1288350.

Bug:  900124 ,856135
Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865
Reviewed-on: https://chromium-review.googlesource.com/c/1317010
Reviewed-by: Lan Wei <azurewei@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605282}
[modify] https://crrev.com/2f0b419df243400f954e11b649f4862a1e0ff367/chrome/browser/extensions/api/input_ime/input_ime_api.cc

Labels: -rel M-71 Merge-Request-71
Labels: -Merge-Request-71 Merge-Approved-71
Merge approved for ChromeOS 71
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 6

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b768d814aae82c5db388c8a5dfd2a4b45426ce1

commit 4b768d814aae82c5db388c8a5dfd2a4b45426ce1
Author: Shu Chen <shuchen@google.com>
Date: Tue Nov 06 01:06:48 2018

Fix the regression caused by http://crrev.com/c/1288350.

Bug:  900124 ,856135
Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865
Reviewed-on: https://chromium-review.googlesource.com/c/1317010
Reviewed-by: Lan Wei <azurewei@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605282}(cherry picked from commit 2f0b419df243400f954e11b649f4862a1e0ff367)
Reviewed-on: https://chromium-review.googlesource.com/c/1318772
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#531}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/4b768d814aae82c5db388c8a5dfd2a4b45426ce1/chrome/browser/extensions/api/input_ime/input_ime_api.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/4b768d814aae82c5db388c8a5dfd2a4b45426ce1

Commit: 4b768d814aae82c5db388c8a5dfd2a4b45426ce1
Author: shuchen@google.com
Commiter: shuchen@chromium.org
Date: 2018-11-06 01:06:48 +0000 UTC

Fix the regression caused by http://crrev.com/c/1288350.

Bug:  900124 ,856135
Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865
Reviewed-on: https://chromium-review.googlesource.com/c/1317010
Reviewed-by: Lan Wei <azurewei@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605282}(cherry picked from commit 2f0b419df243400f954e11b649f4862a1e0ff367)
Reviewed-on: https://chromium-review.googlesource.com/c/1318772
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#531}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
Issue 899408 has been merged into this issue.
Cc: sammiequon@chromium.org blakeo@chromium.org shend@chromium.org ajha@chromium.org wuyingbing@chromium.org
 Issue 899596  has been merged into this issue.
Verified fixed on Version 72.0.3606.0(platform 11256.0.0-18.11.12) dev-channel kevin test
Google_Input_Tools_Version:72.0.20181106.220280811.
Status: Verified (was: Fixed)
Also verified in 72.0.3609.3  11263.0.0 dev-channel scarlet test 
Google input tools version:72.0.20181114.221567824

Sign in to add a comment