New issue
Advanced search Search tips

Issue 900102 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocking:
issue 899586



Sign in to add a comment

Migrate video_ChromeHWDecodeUsed to Tast and run them on CQ

Project Member Reported by keiichiw@chromium.org, Oct 30

Issue description

This bug tracks migrating video_ChromeHWDecodeUsed.* to Tast.
These tests are in bvt-cq.

 
Cc: hiroh@chromium.org dstaessens@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4

commit caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Sat Nov 17 03:50:40 2018

video: Add PlayDecodeAccelUsed* tests

video.PlayDecodeAccelUsed* tests are corresponding to
video_ChromeHWDecodeUsed.* in autotest.

video.PlayDecodeAccelUsed(H264|VP8|VP9) play videos and
check if hardware video decoder was used.
This CL doesn't include autotest's video_ChromeHWDecodeUsed.*.mse
tests, which we decided to change the way of testing.

BUG=chromium:900102
TEST=tast run eve video.PlayDecodeAccelUsed*
TEST=tast run veyron_jerry video.PlayDecodeAccelUsedVP9
     and get error because of lack of VP9 hardware decoder.

Change-Id: I117b49b4307119841669a4335e1ec6017be0fc7c
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1309856
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_h264.go
[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play/play.go
[add] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_vp8.go
[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/playback/playback.go
[add] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_vp9.go
[add] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/lib/histogram/histogram.go
[add] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_h264.go
[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_vp8.go
[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/chrome/metrics/histogram.go
[modify] https://crrev.com/caaa31087f4c8d78337f0b1abdb3a4e2de0cc6d4/src/chromiumos/tast/local/bundles/cros/video/play_vp9.go

Cc: vsu...@chromium.org posciak@chromium.org
 Issue 784742  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/91f3a928788ec7e658cac3f2a6523869c3e5987c

commit 91f3a928788ec7e658cac3f2a6523869c3e5987c
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Wed Nov 21 13:52:45 2018

video: Add PlayDecodeAccelUsedMSE*

video.PlayDecodeAccelUsedMSE(VP8|VP9|H264) tests are corresponding to
video_ChromeHWDecodeUsed.(vp8|vp9|h264).mse in autotest.
These tests check if video can be played properly when Media Source
Extensions (MSE) is used.

While the autotest version accessed crosvideo.appspot.com, the Tast
version use Shaka Player to run tests offline.
Shaka Player plays video streams by using MPEG-DASH.

BUG=chromium:900102
TEST=tast run kevin video.*MSE*
CQ-DEPEND=CL:1343919

Change-Id: Iae6b767a41af3f43e8d1f126e6bf18270ef7e031
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1343832
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/bear-320x240.h264.mpd
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_vp9.go
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_vp8.go
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_vp9.go
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play/play.go
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_h264.go
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_mse_vp9.go
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/bear-320x240.vp9.mpd
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/third_party/shaka-player/README.md
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_mse_h264.go
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/third_party/shaka-player/shaka-player.compiled.debug.js
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/bear-320x240.vp8.mpd
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/third_party/shaka-player/shaka-player.compiled.debug.map
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_h264.go
[modify] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_vp8.go
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/shaka.html
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/play_decode_accel_used_mse_vp8.go
[add] https://crrev.com/91f3a928788ec7e658cac3f2a6523869c3e5987c/src/chromiumos/tast/local/bundles/cros/video/data/third_party/shaka-player/LICENSE

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8f900d638fd82ac464a14085db122f93eea92eb0

commit 8f900d638fd82ac464a14085db122f93eea92eb0
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Wed Nov 21 13:52:45 2018

tast-local-tests-cros: Add video/audio-only files for MPEG-DASH

Add video-only/audio-only files for streaming using Media Source
Extension, which is tested by video.PlayDecodeAccelUsedMSE*.

Add:
 42.63 KiB bear-320x240-audio-only.aac.mp4
 24.98 KiB bear-320x240-audio-only.opus.webm
 23.37 KiB bear-320x240-audio-only.vorbis.webm
 115.2 KiB bear-320x240-video-only.h264.mp4
190.66 KiB bear-320x240-video-only.vp8.webm
 65.79 KiB bear-320x240-video-only.vp9.webm

New files were created by shaka-packager.
e.g.
$ packager \
'input=./bear-320x240.vp8.webm,stream=video,output=bear-320x240-video-only.vp8.webm'\
'input=./bear-320x240.vp8.webm,stream=audio,output=bear-320x240-audio-only.vorbis.webm'\
 --mpd_output bear-320x240.vp8.mpd

BUG=chromium:900102
TEST=None

Change-Id: I33a8f9cba4f26bfa78fb011582108942242920aa
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1343919

[modify] https://crrev.com/8f900d638fd82ac464a14085db122f93eea92eb0/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/8f900d638fd82ac464a14085db122f93eea92eb0/chromeos-base/tast-local-tests-cros/Manifest
[modify] https://crrev.com/8f900d638fd82ac464a14085db122f93eea92eb0/chromeos-base/tast-local-tests-cros/files/external_data.conf

Status: Started (was: Assigned)
Summary: Migrate video_ChromeHWDecodeUsed to Tast and run them on CQ (was: Migrate video_ChromeHWDecodeUsed to Tast)
video.PlayDecodeAccelUsed*, which is Tast version of video_ChromeHWDecodeUsed, were added.
The remaining task is removing "informational" label to run them on Chrome OS CQ.
So, let me modify the summary of this issue.

Sign in to add a comment