New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Crostini Notification - Add UMA

Project Member Reported by tetsui@chromium.org, Oct 30

Issue description

It'd be nice to have UMA for Crostini Notification usage.

One idea is to count number of added notifications per type using enum histogram:

* web
* extension
* ARC++
* Crostini
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4738f54513c36c3b118212fd462414e5e9999ab

commit a4738f54513c36c3b118212fd462414e5e9999ab
Author: Toshiki Kikuchi <toshikikikuchi@google.com>
Date: Thu Nov 01 21:46:38 2018

Add UMA for recording notifier type

This CL adds UMA for recording the number of created notifications for
the various types of sources (e.g. System/ARC++/Crostini).
Also, this CL adds new notifier type for Crostini notifications to
specify the notification comes from Crostini applications.

BUG= chromium:900089 
TEST=compose some notifications and open chrome://histograms

Change-Id: I2d8ef041fa2f8530b9119b4d3a6a598428113665
Reviewed-on: https://chromium-review.googlesource.com/c/1306947
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com>
Cr-Commit-Position: refs/heads/master@{#604713}
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/chrome/browser/notifications/notifier_state_tracker.cc
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/components/exo/notification.cc
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/message_center_stats_collector.cc
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/message_center_stats_collector.h
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/public/cpp/notifier_id.h
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/public/mojo/notifier_id.mojom
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/public/mojo/notifier_id_struct_traits.h
[modify] https://crrev.com/a4738f54513c36c3b118212fd462414e5e9999ab/ui/message_center/views/notification_view_md.cc

Status: Fixed (was: Started)

Sign in to add a comment