Issue 900048 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	akes...@chromium.org
Closed:	Nov 2
Cc:	maruel@google.com no...@chromium.org
Components:	Infra>ChromeOS>Test
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
qscheduler

pull swarming protos go bindings into qslib

Project Member Reported by akes...@chromium.org, Oct 30

Issue description

quotascheduler is going to require some Go code that handles proto messages defined in swarming codebase.

For now, import all these swarming protos into a single sub-package of qslib. Both qslib and quotascheduler-swarming (golang appengine app) will use the protos as imported to that location.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1

commit bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Oct 30 13:05:05 2018

[swarming] add "package swarming" to swarming protos

This allows non-python bindings to be generated. According to
https://developers.google.com/protocol-buffers/docs/proto#packages this
should not affect behavior of any python code that is based on the
python bindings.

BUG= chromium:900048 
TEST=None

Change-Id: If665fe4b3226fffa40436307a0ff894e63329626
Reviewed-on: https://chromium-review.googlesource.com/c/1306819
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1/appengine/swarming/proto/bots.proto
[modify] https://crrev.com/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1/appengine/swarming/proto/bots_pb2.py
[modify] https://crrev.com/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1/appengine/swarming/proto/config.proto
[modify] https://crrev.com/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1/appengine/swarming/proto/config_pb2.py
[modify] https://crrev.com/bf2fdeba64a6c395b817f11bdb6c0c26bf812cb1/appengine/swarming/proto/pools.proto

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d19aa995b3896f8a44490db5fcf14399ccdbda85

commit d19aa995b3896f8a44490db5fcf14399ccdbda85
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Nov 01 18:30:40 2018

swarming: add go bindings from swarming protos

BUG= chromium:900048 
TEST=None

Change-Id: I0c8a29780cea860e73f67ccf0a73c4624ce839d2
Reviewed-on: https://chromium-review.googlesource.com/c/1306839
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18731}
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/gen.go
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/tasks.pb.go
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/config.pb.go
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/README
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/bots.pb.go
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/pools.pb.go
[add] https://crrev.com/d19aa995b3896f8a44490db5fcf14399ccdbda85/go/src/infra/swarming/swarming.infra_testing

Comment 3 by akes...@chromium.org, Nov 2

Labels: qscheduler
Status: Fixed (was: Untriaged)

►

Issue 900048 link

Issue metadata

pull swarming protos go bindings into qslib

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 30

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 1

Comment 2 Deleted

Comment 3 by akes...@chromium.org, Nov 2

Comment 3 Deleted

Sign in to add a comment