PaymentsClientTest.*(components_unittests) failing on chromium.memory/win-asan |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of horo@chromium.org components_unittests failing on chromium.memory/win-asan Builders failed on: - win-asan: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan Failed tests: failures: PaymentsClientTest.UploadIncludesChromeUserContext PaymentsClientTest.UnmaskIncludesChromeUserContext PaymentsClientTest.UnmaskIncludesChromeUserContextIfWalletStorageFlagEnabled PaymentsClientTest.UnmaskSuccessAccountFromSyncTest PaymentsClientTest.UploadIncludesChromeUserContextIfWalletStorageFlagEnabled PaymentsClientTest.MigrationRequestIncludesChromeUserContext PaymentsClientTest.MigrationRequestIncludesChromeUserContextIfWalletStorageFlagEnabled PaymentsClientTest.GetDetailsIncludesChromeUserContext PaymentsClientTest.GetUploadAccountFromSyncTest PaymentsClientTest.GetDetailsIncludesChromeUserContextIfWalletStorageFlagEnabled
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d61f09d656cdeec8acdf4f5be3b22d33e92fceb8 commit d61f09d656cdeec8acdf4f5be3b22d33e92fceb8 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Oct 30 00:31:35 2018 Revert "[base] Harden base::JSONWriter::BuildJSONString" This reverts commit bbe71c7fc70f5c13f966990812b6e654e9b600e8. Reason for revert: Caused win-asan test failure. See crbug.com/900041 Original change's description: > [base] Harden base::JSONWriter::BuildJSONString > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > It replaces the old base::Value API with the new one, thus implicitly > replacing DCHECKs with CHECKs. > > Bug: 859477 > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603508} TBR=rsesek@chromium.org,jdoerrie@chromium.org Change-Id: I526bc8497110b99c5904ae61e4672514047f7412 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859477 Reviewed-on: https://chromium-review.googlesource.com/c/1306954 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603703} [modify] https://crrev.com/d61f09d656cdeec8acdf4f5be3b22d33e92fceb8/base/json/json_writer.cc
,
Oct 30
Issue 900040 has been merged into this issue.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b214250c12bf2f7994e82756eabcd546cd4b39d commit 3b214250c12bf2f7994e82756eabcd546cd4b39d Author: Jan Wilken Doerrie <jdoerrie@chromium.org> Date: Tue Oct 30 14:13:58 2018 Reland "[base] Harden base::JSONWriter::BuildJSONString" This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8 Original change's description: > [base] Harden base::JSONWriter::BuildJSONString > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > It replaces the old base::Value API with the new one, thus implicitly > replacing DCHECKs with CHECKs. > > Bug: 859477 > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603508} Bug: 859477, 900041 Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 Reviewed-on: https://chromium-review.googlesource.com/c/1306356 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#603889} [modify] https://crrev.com/3b214250c12bf2f7994e82756eabcd546cd4b39d/base/json/json_writer.cc
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/155e68132571d78d3e37c5aa1cd9da1b368c312b commit 155e68132571d78d3e37c5aa1cd9da1b368c312b Author: Ioana Pandele <ioanap@chromium.org> Date: Tue Oct 30 17:20:46 2018 Revert "Reland "[base] Harden base::JSONWriter::BuildJSONString"" This reverts commit 3b214250c12bf2f7994e82756eabcd546cd4b39d. Reason for revert: components_unittests/PaymentsClientTest.* failing on Linux ChromiumOS MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Reland "[base] Harden base::JSONWriter::BuildJSONString" > > This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8 > > Original change's description: > > [base] Harden base::JSONWriter::BuildJSONString > > > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > > It replaces the old base::Value API with the new one, thus implicitly > > replacing DCHECKs with CHECKs. > > > > Bug: 859477 > > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603508} > > Bug: 859477, 900041 > Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 > Reviewed-on: https://chromium-review.googlesource.com/c/1306356 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603889} TBR=rsesek@chromium.org,jdoerrie@chromium.org Change-Id: I9db48180d39e9aa4cfd7cb11af1df331d10df39d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859477, 900041 Reviewed-on: https://chromium-review.googlesource.com/c/1308153 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#603939} [modify] https://crrev.com/155e68132571d78d3e37c5aa1cd9da1b368c312b/base/json/json_writer.cc
,
Oct 30
Reverted https://chromium-review.googlesource.com/c/1306356 since it now fails on Linux ChromiumOS MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9350
,
Oct 30
It also failed on Linux MSan Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12609
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdea8bed4c4f917e882dd70165ad5b244e28b262 commit fdea8bed4c4f917e882dd70165ad5b244e28b262 Author: jdoerrie <jdoerrie@chromium.org> Date: Tue Oct 30 22:15:30 2018 Reland "Reland "[base] Harden base::JSONWriter::BuildJSONString"" This is a reland of 3b214250c12bf2f7994e82756eabcd546cd4b39d Original change's description: > Reland "[base] Harden base::JSONWriter::BuildJSONString" > > This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8 > > Original change's description: > > [base] Harden base::JSONWriter::BuildJSONString > > > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > > It replaces the old base::Value API with the new one, thus implicitly > > replacing DCHECKs with CHECKs. > > > > Bug: 859477 > > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603508} > > Bug: 859477, 900041 > Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 > Reviewed-on: https://chromium-review.googlesource.com/c/1306356 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603889} TBR=rsesek@chromium.org Bug: 859477, 900041 Change-Id: I1a825493332a6889afe61897ee9007b651fe86e8 Reviewed-on: https://chromium-review.googlesource.com/c/1308196 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604035} [modify] https://crrev.com/fdea8bed4c4f917e882dd70165ad5b244e28b262/base/json/json_writer.cc [modify] https://crrev.com/fdea8bed4c4f917e882dd70165ad5b244e28b262/components/autofill/core/browser/test_personal_data_manager.h
,
Oct 31
|
||
►
Sign in to add a comment |
||
Comment 1 by horo@chromium.org
, Oct 30