New issue
Advanced search Search tips

Issue 900041 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

PaymentsClientTest.*(components_unittests) failing on chromium.memory/win-asan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 30

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of horo@chromium.org

components_unittests failing on chromium.memory/win-asan

Builders failed on: 
- win-asan: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan

Failed tests:

failures:
PaymentsClientTest.UploadIncludesChromeUserContext
PaymentsClientTest.UnmaskIncludesChromeUserContext
PaymentsClientTest.UnmaskIncludesChromeUserContextIfWalletStorageFlagEnabled
PaymentsClientTest.UnmaskSuccessAccountFromSyncTest
PaymentsClientTest.UploadIncludesChromeUserContextIfWalletStorageFlagEnabled
PaymentsClientTest.MigrationRequestIncludesChromeUserContext
PaymentsClientTest.MigrationRequestIncludesChromeUserContextIfWalletStorageFlagEnabled
PaymentsClientTest.GetDetailsIncludesChromeUserContext
PaymentsClientTest.GetUploadAccountFromSyncTest
PaymentsClientTest.GetDetailsIncludesChromeUserContextIfWalletStorageFlagEnabled
 
Owner: jdoerrie@chromium.org
Looks like caused by jdoerrie@'s JSON change
https://chromium-review.googlesource.com/c/chromium/src/+/1304477

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931315376297765152/+/steps/components_unittests_on_Windows-10-15063/0/logs/PaymentsClientTest.UploadIncludesChromeUserContext/0


[ RUN      ] PaymentsClientTest.UploadIncludesChromeUserContext
=================================================================
==1492==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7ff6458a2625 at pc 0x7ff63adb4c2e bp 0x00dbdc74a070 sp 0x00dbdc74a0b8
READ of size 187 at 0x7ff6458a2625 thread T0
==1492==*** WARNING: Failed to initialize DbgHelp!              ***
==1492==*** Most likely this means that the app is already      ***
==1492==*** using DbgHelp, possibly with incompatible flags.    ***
==1492==*** Due to technical reasons, symbolization might crash ***
==1492==*** or produce wrong results.                           ***
    #0 0x7ff63adb4c57 in __asan_memmove C:\b\rr\tmpagbdek\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_interceptors_memintrinsics.cc:31
    #1 0x7ff63ae475b5 in base::JSONWriter::BuildJSONString C:\b\swarming\w\ir\cache\builder\src\base\json\json_writer.cc:65
    #2 0x7ff63ae483a3 in base::JSONWriter::BuildJSONString C:\b\swarming\w\ir\cache\builder\src\base\json\json_writer.cc:160
    #3 0x7ff63ae483a3 in base::JSONWriter::BuildJSONString C:\b\swarming\w\ir\cache\builder\src\base\json\json_writer.cc:160
    #4 0x7ff63ae46278 in base::JSONWriter::Write C:\b\swarming\w\ir\cache\builder\src\base\json\json_writer.cc:29
    #5 0x7ff63be32e4f in autofill::payments::`anonymous namespace'::UploadCardRequest::GetRequestContent C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client.cc:477
    #6 0x7ff63be2b778 in autofill::payments::PaymentsClient::StartRequest C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client.cc:955
    #7 0x7ff63be2beb1 in autofill::payments::PaymentsClient::SetOAuth2TokenAndStartRequest C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client.cc:910
    #8 0x7ff63be2d1cc in autofill::payments::PaymentsClient::AccessTokenFetchFinished C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client.cc:871
    #9 0x7ff63be37f94 in base::internal::Invoker<base::internal::BindState<void (autofill::payments::PaymentsClient::*)(GoogleServiceAuthError, identity::AccessTokenInfo),base::internal::UnretainedWrapper<autofill::payments::PaymentsClient> >,void (GoogleServiceAuthError, identity::AccessTokenInfo)>::RunOnce C:\b\swarming\w\ir\cache\builder\src\base\bind_internal.h:658
    #10 0x7ff637b659f2 in base::OnceCallback<void (GoogleServiceAuthError, identity::AccessTokenInfo)>::Run C:\b\swarming\w\ir\cache\builder\src\base\callback.h:99
    #11 0x7ff637b6548a in identity::AccessTokenFetcher::RunCallbackAndMaybeDie C:\b\swarming\w\ir\cache\builder\src\services\identity\public\cpp\access_token_fetcher.cc:130
    #12 0x7ff637b65172 in identity::AccessTokenFetcher::OnGetTokenSuccess C:\b\swarming\w\ir\cache\builder\src\services\identity\public\cpp\access_token_fetcher.cc:104
    #13 0x7ff63cbb17e7 in FakeProfileOAuth2TokenService::CompleteRequests C:\b\swarming\w\ir\cache\builder\src\components\signin\core\browser\fake_profile_oauth2_token_service.cc:137
    #14 0x7ff63cbb265e in FakeProfileOAuth2TokenService::IssueTokenForAllPendingRequests C:\b\swarming\w\ir\cache\builder\src\components\signin\core\browser\fake_profile_oauth2_token_service.cc:102
    #15 0x7ff637ff6469 in identity::IdentityTestEnvironment::WaitForAccessTokenRequestIfNecessaryAndRespondWithToken C:\b\swarming\w\ir\cache\builder\src\services\identity\public\cpp\identity_test_environment.cc:272
    #16 0x7ff6300f4918 in autofill::payments::PaymentsClientTest::IssueOAuthToken C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client_unittest.cc:214
    #17 0x7ff6301049cd in autofill::payments::PaymentsClientTest_UploadIncludesChromeUserContext_Test::TestBody C:\b\swarming\w\ir\cache\builder\src\components\autofill\core\browser\payments\payments_client_unittest.cc:690
    #18 0x7ff634e89b32 in testing::Test::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2522
    #19 0x7ff634e8b553 in testing::TestInfo::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2698
    #20 0x7ff634e8c5f4 in testing::TestCase::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2816
    #21 0x7ff634ea5ea9 in testing::internal::UnitTestImpl::RunAllTests C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5182
    #22 0x7ff634ea53eb in testing::UnitTest::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:4791
    #23 0x7ff63bce5e6d in base::TestSuite::Run C:\b\swarming\w\ir\cache\builder\src\base\test\test_suite.cc:294
    #24 0x7ff63bceb44c in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:225
    #25 0x7ff63bceafb2 in base::LaunchUnitTests C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:575
    #26 0x7ff633793f8a in main C:\b\swarming\w\ir\cache\builder\src\components\test\run_all_unittests.cc:20
    #27 0x7ff645858bb7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #28 0x7ffcfe762773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #29 0x7ffd00810d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)




The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61f09d656cdeec8acdf4f5be3b22d33e92fceb8

commit d61f09d656cdeec8acdf4f5be3b22d33e92fceb8
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Oct 30 00:31:35 2018

Revert "[base] Harden base::JSONWriter::BuildJSONString"

This reverts commit bbe71c7fc70f5c13f966990812b6e654e9b600e8.

Reason for revert: Caused win-asan test failure. See  crbug.com/900041 

Original change's description:
> [base] Harden base::JSONWriter::BuildJSONString
> 
> This change simplifies and hardens base::JSONWriter::BuildJSONString().
> It replaces the old base::Value API with the new one, thus implicitly
> replacing DCHECKs with CHECKs.
> 
> Bug: 859477
> Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603508}

TBR=rsesek@chromium.org,jdoerrie@chromium.org

Change-Id: I526bc8497110b99c5904ae61e4672514047f7412
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859477
Reviewed-on: https://chromium-review.googlesource.com/c/1306954
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603703}
[modify] https://crrev.com/d61f09d656cdeec8acdf4f5be3b22d33e92fceb8/base/json/json_writer.cc
 Issue 900040  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b214250c12bf2f7994e82756eabcd546cd4b39d

commit 3b214250c12bf2f7994e82756eabcd546cd4b39d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue Oct 30 14:13:58 2018

Reland "[base] Harden base::JSONWriter::BuildJSONString"

This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8

Original change's description:
> [base] Harden base::JSONWriter::BuildJSONString
>
> This change simplifies and hardens base::JSONWriter::BuildJSONString().
> It replaces the old base::Value API with the new one, thus implicitly
> replacing DCHECKs with CHECKs.
>
> Bug: 859477
> Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603508}

Bug: 859477,  900041 
Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233
Reviewed-on: https://chromium-review.googlesource.com/c/1306356
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603889}
[modify] https://crrev.com/3b214250c12bf2f7994e82756eabcd546cd4b39d/base/json/json_writer.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155e68132571d78d3e37c5aa1cd9da1b368c312b

commit 155e68132571d78d3e37c5aa1cd9da1b368c312b
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Oct 30 17:20:46 2018

Revert "Reland "[base] Harden base::JSONWriter::BuildJSONString""

This reverts commit 3b214250c12bf2f7994e82756eabcd546cd4b39d.

Reason for revert: components_unittests/PaymentsClientTest.* failing on Linux ChromiumOS MSan Tests.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests

Original change's description:
> Reland "[base] Harden base::JSONWriter::BuildJSONString"
> 
> This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8
> 
> Original change's description:
> > [base] Harden base::JSONWriter::BuildJSONString
> >
> > This change simplifies and hardens base::JSONWriter::BuildJSONString().
> > It replaces the old base::Value API with the new one, thus implicitly
> > replacing DCHECKs with CHECKs.
> >
> > Bug: 859477
> > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#603508}
> 
> Bug: 859477,  900041 
> Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233
> Reviewed-on: https://chromium-review.googlesource.com/c/1306356
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603889}

TBR=rsesek@chromium.org,jdoerrie@chromium.org

Change-Id: I9db48180d39e9aa4cfd7cb11af1df331d10df39d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859477,  900041 
Reviewed-on: https://chromium-review.googlesource.com/c/1308153
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603939}
[modify] https://crrev.com/155e68132571d78d3e37c5aa1cd9da1b368c312b/base/json/json_writer.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdea8bed4c4f917e882dd70165ad5b244e28b262

commit fdea8bed4c4f917e882dd70165ad5b244e28b262
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 30 22:15:30 2018

Reland "Reland "[base] Harden base::JSONWriter::BuildJSONString""

This is a reland of 3b214250c12bf2f7994e82756eabcd546cd4b39d

Original change's description:
> Reland "[base] Harden base::JSONWriter::BuildJSONString"
>
> This is a reland of bbe71c7fc70f5c13f966990812b6e654e9b600e8
>
> Original change's description:
> > [base] Harden base::JSONWriter::BuildJSONString
> >
> > This change simplifies and hardens base::JSONWriter::BuildJSONString().
> > It replaces the old base::Value API with the new one, thus implicitly
> > replacing DCHECKs with CHECKs.
> >
> > Bug: 859477
> > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#603508}
>
> Bug: 859477,  900041 
> Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233
> Reviewed-on: https://chromium-review.googlesource.com/c/1306356
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603889}

TBR=rsesek@chromium.org

Bug: 859477,  900041 
Change-Id: I1a825493332a6889afe61897ee9007b651fe86e8
Reviewed-on: https://chromium-review.googlesource.com/c/1308196
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604035}
[modify] https://crrev.com/fdea8bed4c4f917e882dd70165ad5b244e28b262/base/json/json_writer.cc
[modify] https://crrev.com/fdea8bed4c4f917e882dd70165ad5b244e28b262/components/autofill/core/browser/test_personal_data_manager.h

Status: Fixed (was: Available)

Sign in to add a comment