New issue
Advanced search Search tips

Issue 900035 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 30
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay



Sign in to add a comment

PictureInPicturePixelComparisonBrowserTest.VideoPlay is flaky

Project Member Reported by Findit, Oct 30

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad9e8c51aea054095fafa7d8e2147b2e9f4c3877

commit ad9e8c51aea054095fafa7d8e2147b2e9f4c3877
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Oct 30 00:11:01 2018

Revert "Reland "Enable the pixel by pixel comparison test for Mac OS.""

This reverts commit 37618e142085331a792b83bdc14fcc07176f5e93.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603544 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzc2MThlMTQyMDg1MzMxYTc5MmI4M2JkYzE0ZmNjMDcxNzZmNWU5Mww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6189

Sample Failed Step: browser_tests on (none) GPU on Mac

Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay

Original change's description:
> Reland "Enable the pixel by pixel comparison test for Mac OS."
> 
> This is a reland of 01ccf727764c515153478d2bb340f068874d66d5
> 
> Original change's description:
> > Enable the pixel by pixel comparison test for Mac OS.
> > 
> > 1. Tested on Mac and verify everything works as expected.
> > 2. Removed the unnecessary call of GetNativeWindow().
> > 
> > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c
> > Reviewed-on: https://chromium-review.googlesource.com/c/1279301
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#601879}
> 
> Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a
> Reviewed-on: https://chromium-review.googlesource.com/c/1296811
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603544}

Change-Id: Ic8b96d7904653b5f68c5660f045dca15206ac2fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  900035 
Reviewed-on: https://chromium-review.googlesource.com/c/1306785
Cr-Commit-Position: refs/heads/master@{#603698}
[modify] https://crrev.com/ad9e8c51aea054095fafa7d8e2147b2e9f4c3877/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment