Flaky test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6189 Test output log: https://chromium-swarm.appspot.com/task?id=40dad302b007c910 Culprit (100.0% confidence): r603544 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82MTg5L2Jyb3dzZXJfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvVUdsamRIVnlaVWx1VUdsamRIVnlaVkJwZUdWc1EyOXRjR0Z5YVhOdmJrSnliM2R6WlhKVVpYTjBMbFpwWkdWdlVHeGhlUT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PictureInPicturePixelComparisonBrowserTest.VideoPlay&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82MTg5L2Jyb3dzZXJfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvVUdsamRIVnlaVWx1VUdsamRIVnlaVkJwZUdWc1EyOXRjR0Z5YVhOdmJrSnliM2R6WlhKVVpYTjBMbFpwWkdWdlVHeGhlUT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad9e8c51aea054095fafa7d8e2147b2e9f4c3877 commit ad9e8c51aea054095fafa7d8e2147b2e9f4c3877 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Oct 30 00:11:01 2018 Revert "Reland "Enable the pixel by pixel comparison test for Mac OS."" This reverts commit 37618e142085331a792b83bdc14fcc07176f5e93. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603544 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzc2MThlMTQyMDg1MzMxYTc5MmI4M2JkYzE0ZmNjMDcxNzZmNWU5Mww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6189 Sample Failed Step: browser_tests on (none) GPU on Mac Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > Reland "Enable the pixel by pixel comparison test for Mac OS." > > This is a reland of 01ccf727764c515153478d2bb340f068874d66d5 > > Original change's description: > > Enable the pixel by pixel comparison test for Mac OS. > > > > 1. Tested on Mac and verify everything works as expected. > > 2. Removed the unnecessary call of GetNativeWindow(). > > > > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c > > Reviewed-on: https://chromium-review.googlesource.com/c/1279301 > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601879} > > Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a > Reviewed-on: https://chromium-review.googlesource.com/c/1296811 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603544} Change-Id: Ic8b96d7904653b5f68c5660f045dca15206ac2fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900035 Reviewed-on: https://chromium-review.googlesource.com/c/1306785 Cr-Commit-Position: refs/heads/master@{#603698} [modify] https://crrev.com/ad9e8c51aea054095fafa7d8e2147b2e9f4c3877/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 30