New issue
Advanced search Search tips

Issue 900032 link

Starred by 2 users
Status: Fixed
Owner:
timzheng@chromium.org
Closed: Oct 31
Cc:
jkardatzke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Terminal application allows changing density

Project Member Reported by jkardatzke@chromium.org, Oct 30 
Using Chrome OS 11205.0.0 if I right click on the terminal icon in the shelf I get an option for 'use low density' (or 'use high density'). This shouldn't show up for the Terminal since you can't change it's pixel density.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/183c06ca7b38cfcc9eada1a9fff7756e2f195a15

commit 183c06ca7b38cfcc9eada1a9fff7756e2f195a15
Author: Tim Zheng <timzheng@google.com>
Date: Wed Oct 31 16:15:35 2018

No menu item for display density for the terminal.

The default Crostini terminal app is crosh in a Chrome window and the
display density toggle doesn't apply.

BUG=chromium:839242;chromium:900032
TEST=Manually tested on an eve device

Change-Id: I5d7007009803b63590864e107ece80082f9cfb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1308416
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604278}
[modify] https://crrev.com/183c06ca7b38cfcc9eada1a9fff7756e2f195a15/chrome/browser/chromeos/crostini/crostini_registry_service.h
[modify] https://crrev.com/183c06ca7b38cfcc9eada1a9fff7756e2f195a15/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc

Comment 2 by timzheng@chromium.org, Oct 31

Status: Fixed (was: Assigned)
►

Sign in to add a comment