New issue
Advanced search Search tips

Issue 900027 link

Starred by 2 users
Status: Fixed
Owner:
livvielin@chromium.org
Closed: Nov 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Improve contrast of "This page is not secure" overview text

Project Member Reported by livvielin@chromium.org, Oct 29 
The text is currently rgb(253, 177, 48) on #fff. We should change it to something darker, perhaps black? This should be okay now that the neutral state is no longer yellow.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/devtools/front_end/security/mainView.css?l=101
Security overview not secure.png
18.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4050cb84521fe475dd958f2378327ab4662892c8

commit 4050cb84521fe475dd958f2378327ab4662892c8
Author: Livvie Lin <livvielin@chromium.org>
Date: Thu Nov 08 01:06:30 2018

[DevTools] Improve contrast of "This page is not secure" overview text

Updates color from yellow to black (by relying on default color)
to improve contrast and better match neutral state icon color.

Screenshot: https://drive.google.com/file/d/1JMptH0qC9cIyPIzSD99T29Qvm22M4fr-/view?usp=sharing

Bug:  900027 
Change-Id: I1732de356aed28c4c505b5b24cf0e3c666b927fb
Reviewed-on: https://chromium-review.googlesource.com/c/1321858
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606265}
[modify] https://crrev.com/4050cb84521fe475dd958f2378327ab4662892c8/third_party/blink/renderer/devtools/front_end/security/mainView.css

Comment 2 by livvielin@chromium.org, Nov 8

Status: Fixed (was: Assigned)
►

Sign in to add a comment