New issue
Advanced search Search tips

Issue 900025 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 30
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: NativeWindowOcclusionTrackerTest.SimpleOcclusion



Sign in to add a comment

NativeWindowOcclusionTrackerTest.SimpleOcclusion is flaky

Project Member Reported by Findit, Oct 29

Issue description


Flaky test: NativeWindowOcclusionTrackerTest.SimpleOcclusion
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44916
Test output log: https://chromium-swarm.appspot.com/task?id=40daf3c50ddef810
Culprit (100.0% confidence): r603619
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0OTE2L25ldHdvcmtfc2VydmljZV9pbnRlcmFjdGl2ZV91aV90ZXN0cy9UbUYwYVhabFYybHVaRzkzVDJOamJIVnphVzl1VkhKaFkydGxjbFJsYzNRdVUybHRjR3hsVDJOamJIVnphVzl1DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NativeWindowOcclusionTrackerTest.SimpleOcclusion&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0OTE2L25ldHdvcmtfc2VydmljZV9pbnRlcmFjdGl2ZV91aV90ZXN0cy9UbUYwYVhabFYybHVaRzkzVDJOamJIVnphVzl1VkhKaFkydGxjbFJsYzNRdVUybHRjR3hsVDJOamJIVnphVzl1DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adf536f12069e19379095f762fff81d9254ebd5d

commit adf536f12069e19379095f762fff81d9254ebd5d
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Oct 29 23:51:36 2018

Revert "Native window occlusion tracking for windows."

This reverts commit 03b56190ff55b876dc1b4a1398930154240a3170.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603619 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDNiNTYxOTBmZjU1Yjg3NmRjMWI0YTEzOTg5MzAxNTQyNDBhMzE3MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44916

Sample Failed Step: network_service_interactive_ui_tests

Sample Flaky Test: NativeWindowOcclusionTrackerTest.SimpleOcclusion

Original change's description:
> Native window occlusion tracking for windows.
> 
> This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion.
> 
> It is not yet hooked up to the code that treats occluded windows differently.
> 
> Bug: 813093
> Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c
> Reviewed-on: https://chromium-review.googlesource.com/c/1140752
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603619}

Change-Id: Ib25fedcac09b39cda2b5df277febc3cfd12d6eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813093,  900025 
Reviewed-on: https://chromium-review.googlesource.com/c/1306841
Cr-Commit-Position: refs/heads/master@{#603693}
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/chrome/browser/about_flags.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/chrome/test/BUILD.gn
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/BUILD.gn
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/DEPS
[delete] https://crrev.com/c6d4f9008f6275320e0de7e9af9d981fd5a932f8/ui/aura/native_window_occlusion_tracker_unittest.cc
[delete] https://crrev.com/c6d4f9008f6275320e0de7e9af9d981fd5a932f8/ui/aura/native_window_occlusion_tracker_win.cc
[delete] https://crrev.com/c6d4f9008f6275320e0de7e9af9d981fd5a932f8/ui/aura/native_window_occlusion_tracker_win.h
[delete] https://crrev.com/c6d4f9008f6275320e0de7e9af9d981fd5a932f8/ui/aura/native_window_occlusion_tracker_win_interactive_test.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/window_occlusion_tracker.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/window_occlusion_tracker.h
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/window_tree_host.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/window_tree_host.h
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/aura/window_tree_host_observer.h
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/base/ui_base_features.cc
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/base/ui_base_features.h
[modify] https://crrev.com/adf536f12069e19379095f762fff81d9254ebd5d/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

 Issue 900038  has been merged into this issue.
Status: Fixed (was: Untriaged)

Sign in to add a comment