New issue
Advanced search Search tips

Issue 900021 link

Starred by 1 user
Status: Fixed
Owner:
drubery@chromium.org
Closed: Oct 30
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

FileAnalyzer tests don't clean up temp files

Project Member Reported by drubery@chromium.org, Oct 29 
If you run the FileAnalyzer unit tests, it creates the temporary file "tmp.crdownload" in whatever directory you run the tests from. We should write to a temp directory, so that we definitely have write permission, and tmp.crdownload is deleted when the tests finish.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0663d62dc9567278d1c632746115be3b67fbd2b7

commit 0663d62dc9567278d1c632746115be3b67fbd2b7
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Oct 30 17:58:15 2018

Write temporary files in FileAnalyzer unit tests to temporary directory

Currently, temporary files in the FileAnalyzer unit tests are written
wherever the tests were invoked from. This CL writes them to a temporary
directory so that 1) we have write permission, and 2) we clean up after
ourselves.

Bug:  900021 
Change-Id: Ia5390c6444c96a70e736f33b3091c73e3ad97516
Reviewed-on: https://chromium-review.googlesource.com/c/1306661
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603957}
[modify] https://crrev.com/0663d62dc9567278d1c632746115be3b67fbd2b7/chrome/browser/safe_browsing/download_protection/file_analyzer_unittest.cc

Comment 2 by drubery@chromium.org, Oct 30

Status: Fixed (was: Untriaged)
►

Sign in to add a comment