New issue
Advanced search Search tips

Issue 900006 link

Starred by 1 user
Status: Fixed
Owner:
pprabhu@chromium.org
Closed: Dec 10
Cc:
akes...@chromium.org
ayatane@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 891152
issue 910785
Blocking:
issue 888628



Sign in to add a comment

Implement balance_pool in crosskylabadmin

Project Member Reported by pprabhu@chromium.org, Oct 29 
This bug is for:

- Adding the API to the crosskylabadmin app.
- Adding a trivial shell script to call the API from lab-tools

Comment 1 by pprabhu@chromium.org, Oct 29

Blocking: 888628

Comment 2 by pprabhu@chromium.org, Oct 30

Blockedon: 891152
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/53bc6ff34f8cedcbb06e91db9f8f413b959d32bb

commit 53bc6ff34f8cedcbb06e91db9f8f413b959d32bb
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Nov 14 08:04:22 2018

gitiles: Fix license file

BUG= chromium:900006 

Change-Id: Iccbeca3711f690d4aca35f52308d41c41f54db74
Reviewed-on: https://chromium-review.googlesource.com/c/1334767
Auto-Submit: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/53bc6ff34f8cedcbb06e91db9f8f413b959d32bb/common/api/gitiles/rest.go
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/58a31ae955b785b433b4a243f7b20a6b40afac97

commit 58a31ae955b785b433b4a243f7b20a6b40afac97
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Nov 27 21:02:55 2018

gitiles: Regenerate discovery protobuf

Pick up changes in generated code due to compiler upgrade before
incoming functional changes in follow up CLs.

BUG= chromium:900006 

Change-Id: I36ded156923f470006fb5f4df5a1f513653b9e2a
Reviewed-on: https://chromium-review.googlesource.com/c/1352370
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/58a31ae955b785b433b4a243f7b20a6b40afac97/common/proto/gitiles/pb.discovery.go
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/04b3c99e22a34f4aee6354731073f417f33153a0

commit 04b3c99e22a34f4aee6354731073f417f33153a0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Nov 27 21:16:02 2018

gitiles: Extract getRaw

BUG= chromium:900006 

Change-Id: I002e6b0b65e3346fc26715e13d76c0d94c570a3f
Reviewed-on: https://chromium-review.googlesource.com/c/1334443
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/04b3c99e22a34f4aee6354731073f417f33153a0/common/api/gitiles/rest.go
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bc27ea5947af2dd18603701e8fbc706f3623b677

commit bc27ea5947af2dd18603701e8fbc706f3623b677
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Nov 27 21:23:47 2018

crosskylabadmin: Add stub API for balance_pools

BUG= chromium:900006 

Change-Id: Idc12a1cbd6c4aacbd02e7c7b24de27cf02c1f802
Reviewed-on: https://chromium-review.googlesource.com/c/1308548
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19183}
[add] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.pb.go
[add] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory.go
[modify] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/tracker.pb.go
[modify] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/tasker.pb.go
[modify] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/app/frontend/frontend.go
[add] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.proto
[add] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventoryserver_dec.go
[modify] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/gen.go
[modify] https://crrev.com/bc27ea5947af2dd18603701e8fbc706f3623b677/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/pb.discovery.go
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7c15c926fd9d1a3a3a72d102dd9a1ad9bd027b6f

commit 7c15c926fd9d1a3a3a72d102dd9a1ad9bd027b6f
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Nov 27 21:33:28 2018

crosskylabadmin: Rename swarming client creation factory

Make swarming client creation factory and function better before adding
factories for clients of other services.

BUG= chromium:900006 

Change-Id: I46c57ae96bb2078e8f975ea9b20965b5c57340d9
Reviewed-on: https://chromium-review.googlesource.com/c/1334041
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19184}
[modify] https://crrev.com/7c15c926fd9d1a3a3a72d102dd9a1ad9bd027b6f/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker.go
[modify] https://crrev.com/7c15c926fd9d1a3a3a72d102dd9a1ad9bd027b6f/go/src/infra/appengine/crosskylabadmin/app/frontend/tracker.go
[modify] https://crrev.com/7c15c926fd9d1a3a3a72d102dd9a1ad9bd027b6f/go/src/infra/appengine/crosskylabadmin/app/frontend/test_common.go
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/infra_internal/skylab_inventory/+/cf1578ee6dd92a307a1d13ea09ebbecb23080895

commit cf1578ee6dd92a307a1d13ea09ebbecb23080895
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Nov 29 21:30:28 2018
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/infra_internal/skylab_inventory/+/c9e1b26d0427b0f2346415608c939e0b63d056d3

commit c9e1b26d0427b0f2346415608c939e0b63d056d3
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Nov 29 21:38:09 2018
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bfce0019764b613713d622e55fb9aa4c041bddee

commit bfce0019764b613713d622e55fb9aa4c041bddee
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Nov 29 23:06:35 2018

skylab: text format protobufs in python style

BUG= chromium:900006 

Change-Id: I5ff385761e0a0f758982396afd59be21ae68007c
Reviewed-on: https://chromium-review.googlesource.com/c/1354540
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19262}
[modify] https://crrev.com/bfce0019764b613713d622e55fb9aa4c041bddee/go/src/infra/libs/skylab/inventory/inventory.go
[modify] https://crrev.com/bfce0019764b613713d622e55fb9aa4c041bddee/go/src/infra/libs/skylab/inventory/inventory_test.go

Comment 13 by pprabhu@chromium.org, Nov 30

Cc: akes...@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/92d2a28fa7ae20693c5286d4f39340be2fdf46c0

commit 92d2a28fa7ae20693c5286d4f39340be2fdf46c0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Nov 30 01:17:29 2018

skylab: Extract LoadLabFromString, WriteLabToString

BUG= chromium:900006 

Change-Id: I12ecab6815dc0f765f294087d76f9855146e4db6
Reviewed-on: https://chromium-review.googlesource.com/c/1356072
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19269}
[modify] https://crrev.com/92d2a28fa7ae20693c5286d4f39340be2fdf46c0/go/src/infra/libs/skylab/inventory/inventory.go

Comment 17 by pprabhu@chromium.org, Dec 1

Blockedon: 910785
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7ddbbe41e0e6c4215e30a54fa1d51275453d6872

commit 7ddbbe41e0e6c4215e30a54fa1d51275453d6872
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 04 00:28:04 2018

crosskylabadmin: Implement pool balancing in dryrun mode

BUG= chromium:900006 

Change-Id: I99e7279419cde9ca262b2048599a3fc7438c11ce
Reviewed-on: https://chromium-review.googlesource.com/c/1334040
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19310}
[modify] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/inventory.pb.go
[delete] https://crrev.com/0f8a64e8eff3f2597f0456c3c44f59d03ec90b68/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/tasker.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory.go
[modify] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/test_common.go
[modify] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/frontend.go
[modify] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/api/fleet/v1/validation.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/gitiles.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/inventory_test.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/clients/gitiles.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/test_helpers_test.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/test_helpers.go
[add] https://crrev.com/7ddbbe41e0e6c4215e30a54fa1d51275453d6872/go/src/infra/appengine/crosskylabadmin/app/frontend/inventory/pool_balancer.go
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/220eb2f7fc76cab95433e778cb48c1632380c0a1

commit 220eb2f7fc76cab95433e778cb48c1632380c0a1
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 04 20:36:13 2018

gerrit: Fix CreateChange implementation URL

BUG= chromium:900006 

Change-Id: I642463297cfaf71be1a5b84c4e5338d22b1063bc
Reviewed-on: https://chromium-review.googlesource.com/c/1361564
Auto-Submit: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/220eb2f7fc76cab95433e778cb48c1632380c0a1/common/api/gerrit/rest.go
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/43d9a8d1853aa15acaf737bddde133b386141b1d

commit 43d9a8d1853aa15acaf737bddde133b386141b1d
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 04 22:02:53 2018

gerrit: Fix ChangeEdit* RPC client implementations

BUG= chromium:900006 

Change-Id: Idfbe304508dc7728e9d5e5e8b1d1e7e693ca18ee
Reviewed-on: https://chromium-review.googlesource.com/c/1361567
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/43d9a8d1853aa15acaf737bddde133b386141b1d/common/api/gerrit/rest.go
Project Member

Comment 25 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b898178d47723b9140078ed19fbe56f4496a627c

commit b898178d47723b9140078ed19fbe56f4496a627c
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Dec 06 16:41:55 2018
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2c693a91e1c02358a69aeef8922e47eae2a01ca9

commit 2c693a91e1c02358a69aeef8922e47eae2a01ca9
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Dec 06 21:41:44 2018

Roll infra/go/src/go.chromium.org/luci/ 1a51c20bc..9d3688949 (6 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/1a51c20bc545..9d3688949727

$ git log 1a51c20bc..9d3688949 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 hinoka [logdog] Increase logs module min instances to 4 (from 2)
2018-12-05 smut [GCE] Detect case where instance already exists
2018-12-05 pprabhu gerrit: Implement SetReview
2018-12-05 vadimsh [lucicfg] Slightly improve error messages by removing redundant info.
2018-12-05 pprabhu gerrit: Expand ChangeInfo returned by GetChange
2018-12-05 pprabhu gerrit: Implement AbandonChange rpc

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

Bug:  900006 
Change-Id: I64aba0f88eb3562e077e4edbbd6245d1472a3bc2
Reviewed-on: https://chromium-review.googlesource.com/c/1366219
Auto-Submit: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19394}
[modify] https://crrev.com/2c693a91e1c02358a69aeef8922e47eae2a01ca9/DEPS
Project Member

Comment 28 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c395f5790fb55a88d7b3e635022a99117547f4b0

commit c395f5790fb55a88d7b3e635022a99117547f4b0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Dec 07 00:26:36 2018

crosskylabadmin: Forward user's credentials to gitiles, gerrit

BUG= chromium:900006 

Change-Id: I62a1a780f997347b8250321e3043fbf2b0bc8a3f
Reviewed-on: https://chromium-review.googlesource.com/c/1364253
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19405}
[modify] https://crrev.com/c395f5790fb55a88d7b3e635022a99117547f4b0/go/src/infra/appengine/crosskylabadmin/app/clients/gitiles.go
[modify] https://crrev.com/c395f5790fb55a88d7b3e635022a99117547f4b0/go/src/infra/appengine/crosskylabadmin/app/clients/gerrit.go
Project Member

Comment 30 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/infra_internal/skylab_inventory/+/6505b72f41d924023a67217edef422f3d8b2d49f

commit 6505b72f41d924023a67217edef422f3d8b2d49f
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Mon Dec 10 21:51:03 2018

Comment 31 by pprabhu@chromium.org, Dec 10

Status: Fixed (was: Assigned)
Support for ensuring pool health manually has landed.

Example run against prod.

[cr go] pprabhu@pprabhu:go$ skylab ensure-pool-healthy DUT_POOL_BVT nyan_blaze
### Model: nyan_blaze, Target: DUT_POOL_BVT, Spare: DUT_POOL_SUITES
New target pool status: 8/11 healthy
New spare pool status: 0/2 healthy

Inventory changes:
  6a58fd94-64c0-4aef-a416-e9f441a1c762: DUT_POOL_BVT --> DUT_POOL_SUITES
  66c634e8-1da6-414c-b52a-90cd45740922: DUT_POOL_SUITES --> DUT_POOL_BVT
  06321e38-7463-4889-9752-4413899e9880: DUT_POOL_BVT --> DUT_POOL_SUITES
  4997843e-720a-4c4e-bf2e-e6603d0ef975: DUT_POOL_SUITES --> DUT_POOL_BVT

Failures encountered: NOT_ENOUGH_HEALTHY_SPARES

Inventory changes commited at: https://chrome-internal-review.googlesource.com/c/chromeos/infra_internal/skylab_inventory/+/727831


Closing this bug.
Follow up work:

- Automatically ensure pool healthy across all models: issue 913674
- Ensure that models in Skylab have spares in DUT_POOL_SUITES: issue 913675

- Add a tool to resize pools:  issue 913676
►

Sign in to add a comment