Device name greys out while disconnecting |
||||
Issue descriptionGoogle Chrome 72.0.3595.0 (Official Build) canary (64-bit) Revision 8f9f67d1faa88f5dece06904791789cf64c068be-refs/branch-heads/3595@{#1} OS Mac OS X Actual: Device name greys out while disconnecting from an active session. https://screenshot.googleplex.com/Ed9UDSUGMBZ Expected: The device name should stay the same color while disconnecting.
,
Nov 5
Amy: How should we indicate that a device is disconnecting? Maybe change the status text to "Disconnecting..." [1] and/or grey out the stop button? [1] Right now the status text is set to "Connecting..." when connecting
,
Nov 8
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef commit ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Nov 12 19:14:24 2018 [Harmony Cast Dialog] Change status text/icon for various sink states If a sink is DISCONNECTING, change the icon to a throbber and change the status text to "Disconnecting...", but don't grey out the title text. If a sink is AVAILABLE but does not support the selected source, change the status text to "Source not supported". The hashes for the screenshots are per the instructions here: https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o/edit And the screenshots are uploaded here: https://storage.googleapis.com/chromium-translation-screenshots/7f85b1d7787495adf8153366ecc39cdd43762144 https://storage.googleapis.com/chromium-translation-screenshots/7f3bb4aeb5b577e98ab1415b31f967311af8747a Bug: 902493 , 899998 , 883392 Change-Id: Ib556de3e5407500a63c729c7bd02001572fa91e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325070 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#607297} [modify] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/app/media_router_strings.grdp [add] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/app/media_router_strings_grdp/IDS_MEDIA_ROUTER_SINK_DISCONNECTING.png.sha1 [add] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/app/media_router_strings_grdp/IDS_MEDIA_ROUTER_SOURCE_NOT_SUPPORTED.png.sha1 [modify] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc [modify] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h [modify] https://crrev.com/ce7ecc9b3a1d9bdf6fb5115554a642eed6f174ef/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc
,
Nov 12
|
||||
►
Sign in to add a comment |
||||
Comment 1 by powerb@google.com
, Oct 30