Issue metadata
Sign in to add a comment
|
Password Manager UI seems broken in M72 |
||||||||||||||||||||||
Issue descriptionI'm testing 72.0.3592.0 and I found a couple of relatively big issues with Password Manager. Setup: - Be logged out - Go to https://rsolomakhin.github.io/autofill/ Problem 1: 1) Go down to the Name/Password section and pick one of the fill form buttons, then submit 2) Password Manager offers to save the password 3) Clicking [Save] makes the bubble go away without actually clicking Save!! I can click the omnibox icon to bring the bubble back, and *then* click [Save] to save the password. Problem 2: 1) After saving in problem 1, go back to https://rsolomakhin.github.io/autofill/ 2) The password should be prefilled and the key omnibox icon should be showing 3) Clicking the key icon in the omnibox does *absolutely nothing* to the UI. It does scroll my browser to the top of the page, though...?
,
Oct 30
Tested on Mac on 72.0.3596.0 and can't reproduce both problems. What do you mean by "Clicking [Save] makes the bubble go away without actually clicking Save"? For the second problem, open chrome://settings/passwords in another tab. Do you have a credential saved and it's not prefilled? I think a screen recording would clarify a lot. Also what are your variations in chrome://version/ ?
,
Oct 30
Ah, apologies, here's a screenrecording: https://drive.google.com/open?id=1nOT385vw5aO8QHK1_onDMlPyfr8RjzX2 I used to be asked if I wanted to sign in after the password was actually saved, but it's not doing that now. I might have just declined it too many times though. To answer your questions: >> What do you mean by "Clicking [Save] makes the bubble go away without actually clicking Save"? Apparently, the first time I click on the dialog at *all*, it goes away. It's not specifically the [Save] button. Note in the video that when I attempt to click it the first time, the [Save] button's color doesn't change. I just tried again locally and clicking anywhere in the dialog just makes it hide. >> For the second problem, open chrome://settings/passwords in another tab. Do you have a credential saved and it's not prefilled? I made sure to clear all passwords for the site before each trial. >> Also what are your variations in chrome://version/ ? 2c707b42-ca7d8d80 411b6d4e-3f4a17df d01ab0d3-5ac8943 16e0dd70-3f4a17df 2b6ab552-ca7d8d80 66df3e9d-e7f62c8 b7e2524c-f23d1dea da89714-a6a77b22 1d411afe-f23d1dea 9041608a-3f4a17df 9853922b-c200976c 6025934e-3f4a17df 7c1bc906-86bf56d9 9def365c-3f4a17df 47e5d3db-3d47f4f4 d442dfb7-3257dc2 6557d030-f23d1dea 735958b0-3f4a17df a582a1b8-ad75ce17 495970ba-ca7d8d80 249dd49a-28165b59 ac6e1b9-d93a0620 aa011017-a3a14831 66c8e28a-d2306387 3f79ac13-f23d1dea edbcf7c5-961c461c 5485fc4d-3d47f4f4 93731dca-e702d8c4 87a01a8d-ca7d8d80 e111fcd-1410f10 41f007f9-f23d1dea 9b4c4257-3a447918 1b558915-3f4a17df 9874ae0-f23d1dea c992f345-ca7d8d80 9e5c75f1-b73c6342 67fc9f6f-65bced95 2594bdf4-3e4b89c4 350fabdd-34b13816 6fa07eb4-ca7d8d80 4934552d-3f4a17df 95876445-3d200068 d92562a9-65bced95 fc369826-3d47f4f4 67246da1-f23d1dea cc54eb06-33c3eba5 58a025e3-36e97b2c d4d220f9-1c10ba89 ad6d27cc-1627c3cf df072bba-b7b6ded0 8576baf1-3f4a17df 23496387-4ea78229 2e7f6029-c5dfd7a3 51af0496-8fbdaf71 1fcbb124-9aaad08b 4bc337ce-a1f4f53d ad931703-3f4a17df ddf77e2c-a4760aa5 494d8760-52325d43 3ac60855-3ec2a267 f296190c-495cc57e 4442aae2-7158671e ed1d377-e1cc0f14 75f0f0a0-a5822863 e2b18481-a90023b1 e7e71889-4ad60575 f9e5da91-f23d1dea b0ea13bc-dab9d9d 94e68624-f23d1dea cc73f8a1-ca02b375 b4e8892d-3f4a17df 10a311eb-f23d1dea 7e91b7bd-c6da37cb 6204e469-e3d9cd05 81c6897f-3f8c96f0 Thanks for investigating! Hope this helps. Seems 100% reproducible for my Canary so I'm happy to try different things as needed.
,
Oct 30
(Forgot to mention but I updated to the latest Canary when re-testing.)
,
Oct 31
,
Oct 31
Reproduced!! The key important thing is on Mac Setting -> Keyboard -> Shortcuts -> Tab moves between text boxes and lists only. I had it set to all controls.
,
Oct 31
r602568 is a culprit. pbos@ please have a look. If the fix is nontrivial then revert the CL. The password manager bubble isn't usable at the moment.
,
Oct 31
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/211cdf116338d89f59714f9e1d4104bc28ef809d commit 211cdf116338d89f59714f9e1d4104bc28ef809d Author: Peter Boström <pbos@chromium.org> Date: Thu Nov 01 00:37:54 2018 Keep focus inside BubbleDialogDelegateView Removes Widget::SetFocusTraversableParent* calls since we don't want focus to escape bubble dialogs once they get here. There are several bubbles that close once focus escapes. We still set kAnchoredDialogKey of the anchor view to make sure that focus can move into attached dialogs (this makes them keyboard accessible). Bug: chromium:899601 , chromium:899996 Change-Id: Idc5d60c2f41ae20a343324ae75b0fd304f273c94 Reviewed-on: https://chromium-review.googlesource.com/c/1311090 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604464} [modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/bubble/bubble_dialog_delegate_view.cc [modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/bubble/bubble_dialog_delegate_view.h [modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/focus/focus_manager_unittest.cc
,
Nov 1
I'm able to save passwords in Canary both by tab traversing to the dialog and clicking "Save" with the space bar, and by activating it with mouse press. Please verify on your end as well.
,
Nov 1
I can verify that things are back to normal for me as of 72.0.3598.0. Thanks!
,
Nov 1
Perfect, thank you.
,
Nov 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by battre@google.com
, Oct 30Owner: vasi...@chromium.org