New issue
Advanced search Search tips

Issue 899987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Delete Superfish interstitial code

Project Member Reported by livvielin@chromium.org, Oct 29

Issue description

Superfish reports are effectively zero, so we can delete the code for the interstitial.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b7aa951a60fabe332086b0a6340ddc04a70d4ae

commit 5b7aa951a60fabe332086b0a6340ddc04a70d4ae
Author: Livvie Lin <livvielin@chromium.org>
Date: Thu Nov 01 01:48:08 2018

Delete Superfish interstitial code

Metrics show that the Superfish interstitial shows up effectively
0% of the time, and we rarely receive Superfish certificate reports.
This cl deletes the code for the Superfish interstitial.

Bug:  899987 
Change-Id: Ice48aad16fd06d74d1150c306fb5caf62c119022
Reviewed-on: https://chromium-review.googlesource.com/c/1306773
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604482}
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/cert_logger.proto
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/certificate_error_report.h
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_blocking_page.h
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_blocking_page_unittest.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_error_handler.h
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/components/security_interstitials/core/BUILD.gn
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/components/security_interstitials/core/browser/resources/list_of_interstitials.html
[delete] https://crrev.com/68e03620b413364066d031b8d96d31d50242d610/components/security_interstitials/core/superfish_error_ui.cc
[delete] https://crrev.com/68e03620b413364066d031b8d96d31d50242d610/components/security_interstitials/core/superfish_error_ui.h
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/components/security_interstitials_strings.grdp
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/5b7aa951a60fabe332086b0a6340ddc04a70d4ae/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment