New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899982 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 856310



Sign in to add a comment

WebUI: Remove paper-input from the repository

Project Member Reported by dpa...@chromium.org, Oct 29

Issue description

Currently all of the paper-input repository is included under [1]. We should eventually remove all of it, in favor of using cr-input.

paper-input and paper-textarea can already be removed since there are no references to it. paper-input-container and paper-input-error are still used by OOBE which is tracked by issue 856310.

[1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-input/
 
Blockedon: 856310
Labels: -Pri-3 Pri-2
CL in progress at https://chromium-review.googlesource.com/c/chromium/src/+/1306346.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c51314e42d995e17c29ba9224f9294782da1e67

commit 9c51314e42d995e17c29ba9224f9294782da1e67
Author: dpapad <dpapad@chromium.org>
Date: Tue Oct 30 23:28:47 2018

WebUI Polymer: Remove unused polymer elements from the repository.

Removing paper-input, paper-textarea, iron-autogrow-textarea, paper-listbox.

paper-input was only used by paper-slider, if an "editable" boolean is set to
true, which is not the case for any usage of paper-slider. Removed that dependency
in the local paper-slider copy. Also remaining usages of paper-slider will be
replaced with cr-slider sometime soon anyway.

Also remove local patch for paper-input and paper-textarea from chromium.patch.

Bug: 899982,843350
Change-Id: If2e7815259034748db890ac736c32f064ff3c968
Reviewed-on: https://chromium-review.googlesource.com/c/1306346
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604054}
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/chromium.patch
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/bower.json
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-input/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/BUILD.gn
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/paper-listbox-extracted.js
[delete] https://crrev.com/a373adde361a9600cf88c9a5f7e5fa60f0dd1ccb/third_party/polymer/v1_0/components-chromium/paper-listbox/paper-listbox.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-slider/BUILD.gn
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/9c51314e42d995e17c29ba9224f9294782da1e67/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a55851484942b3a3730472893498502740e5cb5b

commit a55851484942b3a3730472893498502740e5cb5b
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 31 21:54:14 2018

WebUI Polymer: Remove unused paper-input-char-counter element.

Also remove PaperInputBehavior. Last usages of these were in paper-input
which was removed recently.

Bug: 899982
Change-Id: I3fc9c741d726851a4c694d73d91aa11159ad8e2d
Reviewed-on: https://chromium-review.googlesource.com/c/1309226
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604382}
[modify] https://crrev.com/a55851484942b3a3730472893498502740e5cb5b/third_party/polymer/v1_0/components-chromium/paper-input/BUILD.gn
[delete] https://crrev.com/bb571bd6cb0a1fbbf5132f114a46801854c6fdf7/third_party/polymer/v1_0/components-chromium/paper-input/all-imports.html
[delete] https://crrev.com/bb571bd6cb0a1fbbf5132f114a46801854c6fdf7/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[delete] https://crrev.com/bb571bd6cb0a1fbbf5132f114a46801854c6fdf7/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior.html
[delete] https://crrev.com/bb571bd6cb0a1fbbf5132f114a46801854c6fdf7/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter-extracted.js
[delete] https://crrev.com/bb571bd6cb0a1fbbf5132f114a46801854c6fdf7/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/a55851484942b3a3730472893498502740e5cb5b/third_party/polymer/v1_0/rsync_exclude.txt
[modify] https://crrev.com/a55851484942b3a3730472893498502740e5cb5b/ui/webui/resources/polymer_resources.grdp

Status: Assigned (was: Started)
Turning this back to "Assigned" since remaining progress is blocked on issue 856310.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5790614e8678a444265a0f944ca23d0165827f38

commit 5790614e8678a444265a0f944ca23d0165827f38
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 15 01:06:52 2018

WebUI cleanup: Remove unused Polymer elements from Desktop builds.

The following elements are only used in ChromeOS, so they don't have
to be included in non-ChromeOS builds

 - iron-input
 - paper-input-container
 - paper-icon-item

Bug:843350,899982

Change-Id: I376e811a6b53fca71ea5a14df479c6f958632547
Reviewed-on: https://chromium-review.googlesource.com/c/1336189
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608206}
[modify] https://crrev.com/5790614e8678a444265a0f944ca23d0165827f38/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d069e4453fcc44ce17f966fa11ac49347ac5cb8

commit 8d069e4453fcc44ce17f966fa11ac49347ac5cb8
Author: dpapad <dpapad@chromium.org>
Date: Tue Dec 18 18:22:58 2018

Settings WebUI: Remove unnecessary iron-input dependency from network-proxy.

Side benefit: This reduces ChromeOS JS bundle size (crisper.js pre-gzip) from
664kb to 660k (still too big though).

Bug: 899982
Change-Id: I797ae23a158ffa6c01a175f3ff2e739001a0d82a
Reviewed-on: https://chromium-review.googlesource.com/c/1381378
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617568}
[modify] https://crrev.com/8d069e4453fcc44ce17f966fa11ac49347ac5cb8/ui/webui/resources/cr_components/chromeos/network/network_proxy.html

Sign in to add a comment