Hitting hardware back button in Downloads home should clear filters. |
||||||
Issue descriptionDevice name: Pixel 3 Application version: 72.0.3591.2 Operating system: Android 9 Steps to reproduce: (1) Enable chrome://flags#download-home-v2 (2) Download at least one file per Download home filter type (Images, Pages, Other (PDF, etc.)) (3) Open Downloads (4) Tap "Images" filter (5) Tap "Pages" filter (6) Tap "Other" filter (7) Tap "Images" filter (8) Tap "Pages" filter (9) Tap "Other" filter (10) Tap hardware back-button (11) Tap hardware back-button Expected result: After hardware back in step (10), "All" filter should be selected. The user clearly wants to clear state by clicking back. After hardware back in step (11), the user is already on "All" and hitting back, so they clearly want downloads home to be closed. Actual result: You have to tap hardware back many, many times to get back to "All", and since you have to tap so many times, you typically end up all the way out in the main activity, not downloads home anymore.
,
Oct 31
,
Nov 1
As this bug is already assigned removing Needs-triage-Mobile label, please feel free to add back if this requires any triage from test team. Thanks!
,
Nov 6
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b002979001b02053c2723bd0672116ebb5cb3ca commit 2b002979001b02053c2723bd0672116ebb5cb3ca Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Nov 07 02:15:19 2018 Download Home : Back button should clear back stack This CL fixes the issue of long backstack for download home filters. With this fix, we would always exit download home when back pressed. While we are on download home, selecting filters will only update the current navigation entry instead of creating a new entry. Bug: 899938 Change-Id: Ia532d1441ff096a78fdc4cb509b4a99ee413ee3f Reviewed-on: https://chromium-review.googlesource.com/c/1309428 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605930} [modify] https://crrev.com/2b002979001b02053c2723bd0672116ebb5cb3ca/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [modify] https://crrev.com/2b002979001b02053c2723bd0672116ebb5cb3ca/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadActivity.java [modify] https://crrev.com/2b002979001b02053c2723bd0672116ebb5cb3ca/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadPage.java [modify] https://crrev.com/2b002979001b02053c2723bd0672116ebb5cb3ca/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/2b002979001b02053c2723bd0672116ebb5cb3ca/chrome/android/java/src/org/chromium/chrome/browser/native_page/BasicNativePage.java
,
Nov 7
kravula@ - Please verify this on M72. Also, this will change the behavior of download home V1, where the dropdown filters will not go back to the previously selected filter any more when back pressed. This code is also related to back button press on bookmarks UI. Please verify if any changes are needed in the bookmarks UI, and file new bug if it needs to be fixed.
,
Nov 7
,
Nov 13
Verified in 72.0.3608.5 build. Now when tap on hardware back button, it is existing the download-Home page |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jbanavatu@chromium.org
, Oct 30