Back-button does not update content area, only visual for selected item |
||||||||||||
Issue descriptionDevice name: Pixel 3 Application version: 72.0.3591.2 Operating system: Android 9 Steps to reproduce: (1) Enable chrome://flags#download-home-v2 (2) Download at least one file per Download home filter type (Images, Pages, Other (PDF, etc.)) (3) Open Downloads (4) Tap "Images" filter (5) Tap "Pages" filter (6) Tap "Other" filter (7) Tap hardware back-button (8) Tap hardware back-button Expected result: "Images" filter is selected, and image content is displayed. Actual result: "Image" filter is selected, but the content still shows the old data, i.e. the 'other' filter data.
,
Oct 30
,
Oct 31
,
Oct 31
,
Nov 1
As issue is already in Started state removing Needs-triage-Mobile label, Please feel free to add if this is necessary. Thanks!
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d3b764b12b41af3cebf40e68182791e913807a5 commit 3d3b764b12b41af3cebf40e68182791e913807a5 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Nov 02 04:40:54 2018 Download Home : Back press doesn't update contents Fixed an issue where the filter change callback was not getting propagated correctly to the mutator, due to which the back button press was unable to update the contents of the tab. Bug: 899936 Change-Id: I46f83fd651a453aba875c62ef47da9d8ee8b2067 Reviewed-on: https://chromium-review.googlesource.com/c/1309427 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604841} [modify] https://crrev.com/3d3b764b12b41af3cebf40e68182791e913807a5/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterCoordinator.java
,
Nov 2
,
Nov 2
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 5
Approved for merge to 71, branch 3578.
,
Nov 5
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa9333f6a2ee9b532e6c94dca87393ace900f1f commit 4aa9333f6a2ee9b532e6c94dca87393ace900f1f Author: Shakti Sahu <shaktisahu@chromium.org> Date: Mon Nov 05 20:03:07 2018 Download Home : Back press doesn't update contents Fixed an issue where the filter change callback was not getting propagated correctly to the mutator, due to which the back button press was unable to update the contents of the tab. Bug: 899936 Change-Id: I46f83fd651a453aba875c62ef47da9d8ee8b2067 Reviewed-on: https://chromium-review.googlesource.com/c/1309427 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604841}(cherry picked from commit 3d3b764b12b41af3cebf40e68182791e913807a5) Reviewed-on: https://chromium-review.googlesource.com/c/1318415 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#514} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/4aa9333f6a2ee9b532e6c94dca87393ace900f1f/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterCoordinator.java
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa9333f6a2ee9b532e6c94dca87393ace900f1f Commit: 4aa9333f6a2ee9b532e6c94dca87393ace900f1f Author: shaktisahu@chromium.org Commiter: shaktisahu@chromium.org Date: 2018-11-05 20:03:07 +0000 UTC Download Home : Back press doesn't update contents Fixed an issue where the filter change callback was not getting propagated correctly to the mutator, due to which the back button press was unable to update the contents of the tab. Bug: 899936 Change-Id: I46f83fd651a453aba875c62ef47da9d8ee8b2067 Reviewed-on: https://chromium-review.googlesource.com/c/1309427 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604841}(cherry picked from commit 3d3b764b12b41af3cebf40e68182791e913807a5) Reviewed-on: https://chromium-review.googlesource.com/c/1318415 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#514} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by shaktisahu@chromium.org
, Oct 29