Issue metadata
Sign in to add a comment
|
SpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord is flaky |
||||||||||||||||||||
Issue descriptionSpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXAsSBUZsYWtlIlFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNwZWxsaW5nTWVudU9ic2VydmVyVGVzdC5Ob1NwZWxsaW5nU2VydmljZVdoZW5PZmZUaGVSZWNvcmQM. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20SpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXAsSBUZsYWtlIlFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNwZWxsaW5nTWVudU9ic2VydmVyVGVzdC5Ob1NwZWxsaW5nU2VydmljZVdoZW5PZmZUaGVSZWNvcmQM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Oct 30
Issue 899904 has been merged into this issue.
,
Oct 30
The other flaky test is SpellingMenuObserverTest.SuggestionsForceTopSeparator [20148:19944:1029/063310.689:FATAL:thread_restrictions.cc(34)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
,
Oct 30
Disable the tests https://chromium-review.googlesource.com/c/chromium/src/+/1307894
,
Oct 30
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e173df2e0c14a773ddee32b1b7f295f690000e81 commit e173df2e0c14a773ddee32b1b7f295f690000e81 Author: Owen Min <zmin@chromium.org> Date: Tue Oct 30 16:49:50 2018 Disable two SpellingMenuObserverTest Disable SpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord SpellingMenuObserverTest.SuggestionsForceTopSeparator Bug: 899935 Change-Id: Ib5f1089e3be0e9c89805debc064435c0a70a7c17 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1307894 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603928} [modify] https://crrev.com/e173df2e0c14a773ddee32b1b7f295f690000e81/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
,
Oct 30
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Oct 30