New issue
Advanced search Search tips

Issue 899922 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Oct 29
Components:
EstimatedDays: 1
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Scenic integration is broken in trunk

Project Member Reported by sergeyu@chromium.org, Oct 29 
allocation_size filed was added in MemoryInfo struct, but that field is not filled in in chromium, so scenic fails with the following error: 

[08531.830] [ERROR:garnet/lib/ui/scenic/session.cc(142)] Image::CreateFromMemory(): the offset of the Image must be within the range of the Memory
[08531.833] [ERROR:garnet/lib/ui/scenic/session.cc(142)] scenic_impl::gfx::Session::ApplyCommand() failed to apply Command: CreateResourceCmd(id:8 Image)


Pending fix: https://chromium-review.googlesource.com/c/chromium/src/+/1306174/2
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfff248c8b3f02b8eebdead375329533b88118f6

commit cfff248c8b3f02b8eebdead375329533b88118f6
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Oct 29 21:34:31 2018

[fuchsia] Pass allocation_size for Memory resources in Scenic

Scenic now expects allocation_size to be set for VMOs. That parameter
wasn't set in chromium, so Scenic would fail when trying to use VMOs for
images.

Bug:  899922 

Change-Id: I73c7c7dfa4d4a5e9ba76774c4b69d8125add05c2
Reviewed-on: https://chromium-review.googlesource.com/c/1306174
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603634}
[modify] https://crrev.com/cfff248c8b3f02b8eebdead375329533b88118f6/ui/ozone/platform/scenic/scenic_session.cc
[modify] https://crrev.com/cfff248c8b3f02b8eebdead375329533b88118f6/ui/ozone/platform/scenic/scenic_session.h
[modify] https://crrev.com/cfff248c8b3f02b8eebdead375329533b88118f6/ui/ozone/platform/scenic/scenic_window_canvas.cc

Comment 2 by sergeyu@chromium.org, Oct 29

Status: Fixed (was: Started)
►

Sign in to add a comment