New issue
Advanced search Search tips

Issue 899902 link

Starred by 1 user
Status: Fixed
Owner:
kojii@chromium.org
Closed: Nov 7
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[LayoutNG] Shield emoji displays in the wrong place

Project Member Reported by nhar...@chromium.org, Oct 29 
Chrome Version: 70.0.3538.77
OS: gLinux

What steps will reproduce the problem?
(1) In Hangouts Chat, create a room with the name "this is a long name with a shield at the end 🛡️"
(2) Observe the name of the group under "RECENT" on the left side

What is the expected result?

A truncated name "this is a long name with a shield..." should appear

What happens instead?

The truncated name appears, but the shield emoji overlaps the word "this" at the beginning (see attached screenshot).

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Screenshot from 2018-10-29 13-18-21.png
3.0 KB View Download

Comment 1 by e...@chromium.org, Nov 5

Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by kojii@chromium.org, Nov 6 

Thank you for reporting this problem to us.

Minimized case attached. It looks like applying "transform" can make the icon visible.
ellipsis-899902.html
685 bytes View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce828bebf2bae168f51ed62242faef5c5316d121

commit ce828bebf2bae168f51ed62242faef5c5316d121
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Nov 07 08:36:02 2018

[LayoutNG] SelfPaintingLayer is left visible when ellipsized

NGLineTruncator truncates lines by suppressing fragments to
be clipped. However, when such fragments have
SelfPaintingLayer, they are still painted by LayerPainter.

This patch moves such fragments to the outside of the
clipping area, the same way we used to use until r581177.

Note that we used to move to line_width before r581177,
but it's not enough when the block has padding. This
patch moves to NearlyMax instead.

Bug:  899902 
Change-Id: I6192f230e2da3af11346acb5795483f9cc3a6a6a
Reviewed-on: https://chromium-review.googlesource.com/c/1319889
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605996}
[modify] https://crrev.com/ce828bebf2bae168f51ed62242faef5c5316d121/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/ce828bebf2bae168f51ed62242faef5c5316d121/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/ce828bebf2bae168f51ed62242faef5c5316d121/third_party/WebKit/LayoutTests/fast/text/ellipsis-with-self-painting-layer-expected.html
[add] https://crrev.com/ce828bebf2bae168f51ed62242faef5c5316d121/third_party/WebKit/LayoutTests/fast/text/ellipsis-with-self-painting-layer.html
[modify] https://crrev.com/ce828bebf2bae168f51ed62242faef5c5316d121/third_party/blink/renderer/core/layout/ng/inline/ng_line_truncator.cc

Comment 4 by kojii@chromium.org, Nov 7

Status: Fixed (was: Assigned)
This should be fixed now.
►

Sign in to add a comment