SBER/PasswordProtectionServiceTest.VerifyContentTypeIsPopulated/0 is slow |
||
Issue descriptionThis test consistently takes 10s to run on my linux workstation, which is way too slow for a unit test. I noticed the test has a 10s timeout, maybe it's related?
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c00450e689317523780965aa0c8dc3d3a1b7fe4c commit c00450e689317523780965aa0c8dc3d3a1b7fe4c Author: Daniel Rubery <drubery@chromium.org> Date: Sat Nov 03 01:30:13 2018 Fix SBER/PasswordProtectionServiceTest.VerifyContentTypeIsPopulated/0 This unit test currently waits for the timeout on network requests to occur before it verifies the proper request was sent. This CL adds a fake response so that the test runs quickly. Bug: 899898 Change-Id: I9e35086647cc80344488abb3319a538e90785eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1316411 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605120} [modify] https://crrev.com/c00450e689317523780965aa0c8dc3d3a1b7fe4c/components/safe_browsing/password_protection/password_protection_service_unittest.cc
,
Nov 5
|
||
►
Sign in to add a comment |
||
Comment 1 by vakh@chromium.org
, Nov 2Owner: drubery@chromium.org
Status: Assigned (was: Untriaged)