Issue metadata
Sign in to add a comment
|
Incorrect icon gets used for splash screen when service worker is enabled
Reported by
jacob.be...@gmail.com,
Oct 29
|
||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Create a new web app with a manifest.json containing a set of icons sized 48x48, 96x96, 192x192, 256x256, and 512x512 and include a simple service worker. 2. Visit the app on an Android phone and add it to your home screen. 3. Launch the app from the home screen and observe that the 192x192 icon is used rather than the 512x512. What is the expected behavior? The 512x512 icon should be used for the splash screen. What went wrong? The 192x192 icon is used for the splash screen. Did this work before? Yes Unknown Does this work in other browsers? Yes Chrome version: 70.0.3538.64 Channel: stable OS Version: 9 Flash Version: This error only occurs when a service worker is registered; if no service worker exits, the 512x512 icon is correctly used.
,
Oct 30
,
Nov 1
This is probably because when a service worker is registered, we create a WebAPK, which use different splashscreen rules. Over to the WebAPK folks.
,
Nov 1
Removing Needs-triage-Mobile as this is already assigned, Please feel free to add back if this is necessary. Thanks!
,
Nov 1
Can you test in beta and see whether this repros? Also, what model phone (or simply display density) is the device you're using
,
Nov 1
I've tested on a Pixel XL, a Pixel 2 XL, a Nexus 5X, a Galaxy S7, and a Nexus 9, and all have the same issue. It does seem to be working in the beta channel, although there the icon is behaving oddly (appears against a white background on my Pixel 2 XL, did you guys implement the masking purpose in beta?)
,
Nov 1
Cool. On beta we've updated the apks to a new layout which perhaps fixed the layout issues. Re: the white masking, the update also target the P SDK (from N previously). Because the target SDK moved past O, we now get the presumption of adaptive icons. However, we haven't yet implemented support for them (issue 862041) so this will be the case for a little while. The good news is that the spec for this has recently landed so there's a path forward |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jbanavatu@chromium.org
, Oct 30