New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899872 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Redesigned wallpaper picker issues

Reported by jirik.se...@gmail.com, Oct 29

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11151.11.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.21 Safari/537.36
Platform: 11151.11.0 (Official Build) beta-channel lars

Steps to reproduce the problem:
1. Enable the new wallpaper picker by chrome://flags/#enable-new-wallpaper-picker set to Enabled
2. Select My Images tab - your own custom wallpapers are missing and factory wallpaper (in my case from Acer) is missing too
3. Select Landscapes tab - scroll through wallpapers, many of them are repeating, e.g. Aerial view of airliners in the desert

What is the expected behavior?
1. Enable the old wallpaper picker by chrome://flags/#enable-new-wallpaper-picker set to Disabled
2. Select Custom tab - your own custom wallpapers are present and factory wallpaper is here too
3. Select Landscapes tab - scroll through wallpapers, no one is duplicated

What went wrong?
See the comparison of both version of wallpaper picker in attached snapshots

Did this work before? Yes Just enable the old wallpaper picker by chrome://flags/#enable-new-wallpaper-picker set to Disabled

Chrome version: 71.0.3578.21  Channel: beta
OS Version: 11151.11.0
Flash Version: 31.0.0.122 

Tested on Acer Chromebook 14 for Work (CP5-471)
 
Old wallpaper picker.png
49.8 KB View Download
Redesigned wallpaper picker.png
58.5 KB View Download
Components: -UI UI>Shell>Wallpaper
Owner: wzang@chromium.org
Thanks for the feedback. I can't reproduce  issue 3 ). Could you send a screenshot to show which images are repeating?

1) and 2) are intentional. The new wallpaper picker does not show the wallpaper history or factory wallpaper.
> Could you send a screenshot to show which images are repeating?

I prepared a small demonstration video, because there is a whole bunch of duplicated pictures. So I chose one of them - the famous "Aerial view of airliners in the desert" for easy searching. Please, observe moving vertical scroll bar as a confirmation that selected picture is appearing twice on two different places and close pictures around it too.

> 1) and 2) are intentional

And the reason for this is?
Please explain then, how we can now select own custom wallpapers which are saved in Chrome Syncable FileSystem on Google Drive and how we can now select original factory wallpaper which is saved somewhere on the device? Both was possible in previous wallpaper picker version for years.

I have disabled chrome://flags/#enable-new-wallpaper-picker to be able to use these features now, but this flag could disappear anytime in the future.

Aerial view of airliners in the desert.mp4
4.5 MB View Download
Cc: omrilio@chromium.org elizabethchiu@chromium.org pujolj@google.com
Status: Assigned (was: Unconfirmed)
Thanks for the video!

+James, the duplicate image is a server-side issue. Could you help triage this? Thanks! (You should be able to reproduce the issue on the device I handed to you.)

+Omri, showing the factory default wallpaper is straightforward. I'm working on it now. However, showing the wallpaper history is not part of the new wallpaper picker mock, and now it's quite complex to add them. Do we have a reason why this is not included in the original design? (I assume it's because there're very few users actually caring about wallpaper history?)
Cc: -pujolj@google.com rgauba@google.com
Owner: pujolj@google.com
Assigning to pujolj@ for investigation on 3) (the image duplication)

I'll land the fix for 1) today.
Thank you very much for such a quick and thorough response.
As a workaround in the future one should download own custom wallpapers from Chrome Syncable FileSystem on Google Drive.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd49446db0691f60a0492edfca68db51a971ec0d

commit fd49446db0691f60a0492edfca68db51a971ec0d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Oct 31 00:51:57 2018

cros: Add OEM wallpaper back to wallpaper picker

The added code is mostly the ones deleted in https://chromium-review.googlesource.com/c/chromium/src/+/1297308
as part of "old-wallpaper-picker only" code path.

Bug: 899872
Change-Id: I7dbad13c00d50841091b9f51656428025efae096
Reviewed-on: https://chromium-review.googlesource.com/c/1308936
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604086}
[modify] https://crrev.com/fd49446db0691f60a0492edfca68db51a971ec0d/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/fd49446db0691f60a0492edfca68db51a971ec0d/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/fd49446db0691f60a0492edfca68db51a971ec0d/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Re #6, thanks. The factory default wallpaper is added back now, and it will be included in M72. (The #enable-new-wallpaper-picker flag will be removed in M72.)

Please use Chrome Syncable FileSystem as workaround for now. Thanks! (Actually, I was about to land code to delete all the history custom wallpapers in Chrome Syncable FileSystem, because we wanted to completely remove the support for wallpaper history, but based on your feedback, for now we'll keep it as an alternative option.)
I apologize very much, but in the opening post I forgot to mention one more issue. I highlighted it in the attached picture, there is sometime displayed remnant of some text.
Screenshot 2018-10-31 at 18.58.05.png
74.5 KB View Download
Status: Fixed (was: Assigned)
Cc: pujolj@google.com
Owner: wzang@google.com
Status: Unconfirmed (was: Fixed)
#3 image duplication has been fixed.
Owner: wzang@chromium.org
Status: Assigned (was: Unconfirmed)
Re #9, sorry! I missed this comment. I can't reproduce this issue though, how often does it happen on your device? Thanks!
Not so often, from time to time, randomly.
I hoped that displayed remnant of some text will be your key for searching in code.
Labels: Hotlist-ConOps-CrOS Hotlist-ConOps-Source-Forum

Sign in to add a comment