New issue
Advanced search Search tips

Issue 899860 link

Starred by 1 user
Status: Assigned
Owner:
afakhry@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make sure top-controls-slide works with mash (multi process)

Project Member Reported by est...@chromium.org, Oct 29 
splitting this off from  bug 897823 

9/11 time out for me locally:
    TopControlsSlideControllerTest.DisplayRotation (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:786)
    TopControlsSlideControllerTest.TestClosingATab (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:636)
    TopControlsSlideControllerTest.TestDropDowns (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:906)
    TopControlsSlideControllerTest.TestFocusEditableElements (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:684)
    TopControlsSlideControllerTest.TestIntermediateSliding (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:1048)
    TopControlsSlideControllerTest.TestPermissionBubble (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:1131)
    TopControlsSlideControllerTest.TestScrollingMaximizedPageBeforeGoingToTabletMode (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:954)
    TopControlsSlideControllerTest.TestScrollingPage (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:557)
    TopControlsSlideControllerTest.TestToggleChromeVox (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:1207)

On one run of the mojo FYI bot I see these failures:
-TopControlsSlideControllerTest.TestDropDowns
-TopControlsSlideControllerTest.TestPermissionBubble
-TopControlsSlideControllerTest.TestToggleChromeVox
-TopControlsSlideControllerTest.TestIntermediateSliding

Comment 1 by afakhry@chromium.org, Oct 29 

Can you post a link to the failing bot? I need to know with what flags the tests are run.

Comment 2 by est...@chromium.org, Oct 29 

The local run was:
./out/mustash/browser_tests --enable-features=Mash --gtest_filter=TopControlsSlideControllerTest*

The FYI bot is here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_mojo_chromeos/281

with command:
./browser_tests --brave-new-test-launcher --test-launcher-bot-mode --cfi-diag=0 --enable-features=Mash --override-use-software-gl-for-tests --test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter --gtest_filter=AutotestPrivateApiTest.AutotestPrivate:ExtensionDialogBoundsTest.Test_BigExtensionDialog:ExtensionDialogBoundsTest.Test_OpenFileDialog:MemoryTracingBrowserTest.TestMemoryInfra:PolicyTest.VirtualKeyboardEnabled:SelectFileDialogExtensionBrowserTest.SelectFileVirtualKeyboard_TabletMode:ShelfAppBrowserTest.SettingsAndTaskManagerWindows:ShutdownPolicyLockerTest.PolicyChange:ShutdownPolicyLockerTest.TestBasic:TopControlsSlideControllerTest.TestDropDowns:TopControlsSlideControllerTest.TestIntermediateSliding:TopControlsSlideControllerTest.TestPermissionBubble:TopControlsSlideControllerTest.TestToggleChromeVox:WebRtcGetDisplayMediaBrowserTestWithFakeUI.GetDisplayMedia/2:WebRtcGetDisplayMediaBrowserTestWithFakeUI.GetDisplayMediaWithConstraints/2 --test-launcher-summary-output=/b/s/w/iouwLnwo/output.json

Comment 3 by weifangsun@chromium.org, Nov 8 

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!
►

Sign in to add a comment