New issue
Advanced search Search tips

Issue 899839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
q4



Sign in to add a comment

[IOS tab refactoring] Remove parentTabModel from tab

Project Member Reported by mrefaat@chromium.org, Oct 29

Issue description

This depends on -view removal. After the removal of it, shouldn't be hard to remove parentTabModel.
 
Labels: OS-iOS
Labels: -O-ios-tab-remove-after S-ios-tab-remove-after
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f3229d03a7015460c2469959bd83053d60d6ca3

commit 0f3229d03a7015460c2469959bd83053d60d6ca3
Author: mrefaat <mrefaat@chromium.org>
Date: Tue Nov 27 20:42:12 2018

Update viewForTab to use BVC own tabmodel

Previously it used to use tab.tabmodel which is going to be deleted.

Bug:  899839 
Change-Id: I86584dfcd6bae44b289585fe1562c2f160715406
Reviewed-on: https://chromium-review.googlesource.com/c/1321669
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611294}
[modify] https://crrev.com/0f3229d03a7015460c2469959bd83053d60d6ca3/ios/chrome/browser/ui/browser_view_controller.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/294074dc88d7b4c8a9b1a8293ed6219936490a0f

commit 294074dc88d7b4c8a9b1a8293ed6219936490a0f
Author: mrefaat <mrefaat@chromium.org>
Date: Tue Nov 27 23:25:20 2018

[IOS Tab Refactoring] Remove TabModel as a member of Tab

Update TabModelWebStateListDelegate so it doesn't need TabModel
 object as there is no need to set parentModel for the tab anymore.

Bug:  899839 , 228575
Change-Id: I68ff2d4672423b36fbbb171d9f183f3506d39be5
Reviewed-on: https://chromium-review.googlesource.com/c/1320792
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611406}
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab_model_unittest.mm
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab_model_web_state_list_delegate.h
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab_model_web_state_list_delegate.mm
[modify] https://crrev.com/294074dc88d7b4c8a9b1a8293ed6219936490a0f/ios/chrome/browser/tabs/tab_private.h

Status: Fixed (was: Assigned)
Blockedon: -899832

Sign in to add a comment