New issue
Advanced search Search tips

Issue 899832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
q4



Sign in to add a comment

[IOS Tab Refactoring] Remove -view from tab

Project Member Reported by mrefaat@chromium.org, Oct 29

Issue description

This method depends on webState entirely it should be easy to inline in the browserViewController. It also need the tabmodel which is available on BrowserViewController

 
Blocking: 899839
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb094bc496eb719b88ff264e8f509a649c33243

commit 3cb094bc496eb719b88ff264e8f509a649c33243
Author: mrefaat <mrefaat@chromium.org>
Date: Mon Nov 05 20:17:09 2018

[IOSTabRefactoring] Replace tab.view by webState.GetView()

This CL to prepare for removing -view method from Tab

Bug:  899832 
Change-Id: Iebe22114e1b478bb41e418e66c5ba5b85109166e
Reviewed-on: https://chromium-review.googlesource.com/c/1318178
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605437}
[modify] https://crrev.com/3cb094bc496eb719b88ff264e8f509a649c33243/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/3cb094bc496eb719b88ff264e8f509a649c33243/ios/chrome/browser/tabs/tab_unittest.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b05d645433af37a8c40fde66421ecdbe868ae2

commit 03b05d645433af37a8c40fde66421ecdbe868ae2
Author: mrefaat <mrefaat@chromium.org>
Date: Wed Nov 14 20:45:31 2018

[IOSTabRefactoring] Inline -view from Tab in BVC

-view used by the BVC - so instead move the functionality to viewForTab

Bug:  899832 
Change-Id: I9958174df2468a7be4d1ab13c4f29cff3f81b2fb
Reviewed-on: https://chromium-review.googlesource.com/c/1313282
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608114}
[modify] https://crrev.com/03b05d645433af37a8c40fde66421ecdbe868ae2/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/03b05d645433af37a8c40fde66421ecdbe868ae2/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/03b05d645433af37a8c40fde66421ecdbe868ae2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/03b05d645433af37a8c40fde66421ecdbe868ae2/ios/chrome/browser/ui/browser_view_controller_unittest.mm

Status: Fixed (was: Assigned)
Blocking: -899839
Labels: -small medium

Sign in to add a comment