New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899805 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Detection: rank flakes by a single score

Project Member Reported by chanli@chromium.org, Oct 29

Issue description

Since Flake Detector can detect different types of flakes, we need a more reasonable way to rank flakes with different types of occurrences.

Currently approach is to calculate a single score based on the number of occurrences(impacted Cls) and impact of each flake type.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea

commit 2f18ac8f9289a40ab6e897ba91a56dafe03c4eea
Author: Chan <chanli@chromium.org>
Date: Thu Nov 15 20:41:50 2018

[Findit] Rank flakes by a single score.

When update flakes, count distinct impacted CLs of different types of flake occurrences for each flake and use those counts to calculate a single score.

Bug: 899805
Change-Id: I0975733adcc015d34d56733f160cf7f44011f6e6
Reviewed-on: https://chromium-review.googlesource.com/c/1305120
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19025}
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/services/flake_detection/update_flake_counts_service.py
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/index.yaml
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/services/flake_detection/test/update_flake_counts_service_test.py
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/model/flake/flake.py
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/handlers/flake/detection/test/show_flake_test.py
[modify] https://crrev.com/2f18ac8f9289a40ab6e897ba91a56dafe03c4eea/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cea2fd680808b86e006d5ad1edfe136fb52cbaab

commit cea2fd680808b86e006d5ad1edfe136fb52cbaab
Author: Chan <chanli@chromium.org>
Date: Fri Nov 16 00:26:38 2018

[Findit] Use the new score to rank flakes.

In this change, the handler is updated to query flakes by the new score; and UI is updated as well.

Noted the UI change here is only to adjust columns. I will have a separate CL to add explanations to each score.

Bug: 899805
Change-Id: I145540a084668aad3db83703a6962d04cc3f421b
Reviewed-on: https://chromium-review.googlesource.com/c/1305793
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19038}
[modify] https://crrev.com/cea2fd680808b86e006d5ad1edfe136fb52cbaab/appengine/findit/index.yaml
[modify] https://crrev.com/cea2fd680808b86e006d5ad1edfe136fb52cbaab/appengine/findit/handlers/flake/detection/test/rank_flakes_test.py
[modify] https://crrev.com/cea2fd680808b86e006d5ad1edfe136fb52cbaab/appengine/findit/ui/elements/flake_detection/rank_flakes.html
[modify] https://crrev.com/cea2fd680808b86e006d5ad1edfe136fb52cbaab/appengine/findit/templates/flake/detection/rank_flakes.html
[modify] https://crrev.com/cea2fd680808b86e006d5ad1edfe136fb52cbaab/appengine/findit/handlers/flake/detection/rank_flakes.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18

Sign in to add a comment