default behavior for "cros flash $IP" change? |
|||
Issue description
~/trunk/src/third_party/kernel/v4.4 $ cros flash eve-33.lab
09:40:54: NOTICE: Preparing to update the remote device eve-33.lab
09:40:55: ERROR: Locating image "latest" failed. The path might not be valid or the image might not exist.
09:40:55: ERROR: Device update failed.
...
09:40:55: ERROR: Cannot locate image latest: No images found in /mnt/host/source/devserver/static/eve/latest
The error message is correct: "latest" doesn't exist there. "latest" only exists in my src/build/images/eve directory.
Is this a recently introduced bug into one of the tools?
$ ls -l /mnt/host/source/devserver/static/eve
total 4
lrwxrwxrwx 1 root root 68 Oct 29 09:47 R72-11189.0.2018_10_26_1556-a1 -> /mnt/host/source/src/build/images/eve/R72-11189.0.2018_10_26_1556-a1
$ ls -l /mnt/host/source/src/build/images/eve/
total 4
lrwxrwxrwx 1 grundler eng 30 Oct 26 16:05 latest -> R72-11189.0.2018_10_26_1556-a1
drwxr-xr-x 3 grundler eng 4096 Oct 26 16:05 R72-11189.0.2018_10_26_1556-a1
Mike responded:
> please file a bug. it's probably unintended behavior of a
> recent change related to deleting get_latest_image script.
BTW, if someone is touching the code here anyway, the --help has contradicting statements about the default location (remote vs local) :
...
positional arguments:
...
image A local path or an xbuddy path:
xbuddy://{local|remote}/board/version/{image_type}
image_type can be: 'test', 'dev', 'base', 'recovery',
or 'signed'. Note any strings that do not map to a
real file path will be converted to an xbuddy path
i.e., latest, will map to xbuddy://latest.
...
To update/image the device with the latest locally built image:
cros flash device latest
cros flash device
I believe the examples are correct: "locally built" image is used.
,
Oct 30
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/77df93524a3bc00c5585784aea7aba2588cdcb79 commit 77df93524a3bc00c5585784aea7aba2588cdcb79 Author: Alex Klein <saklein@chromium.org> Date: Wed Oct 31 19:42:39 2018 cros flash: read latest link to resolve a revision BUG= chromium:899801 TEST=precq Change-Id: Ice26b19ff0b99aa1d4a8cdb1cf4987cc3d025f3f Reviewed-on: https://chromium-review.googlesource.com/1308313 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/77df93524a3bc00c5585784aea7aba2588cdcb79/build_util.py [modify] https://crrev.com/77df93524a3bc00c5585784aea7aba2588cdcb79/xbuddy.py
,
Nov 1
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vapier@chromium.org
, Oct 29Owner: saklein@chromium.org