Generated password not masked after tapping outside of field |
||||
Issue descriptionOS: Android What steps will reproduce the problem? (1) Navigate to a sign up form (e.g. imbd.com > Sign in > Create a new account) (2) Tap on the new password field and generate a password. (3) Tap on the generated password field then outside (note: not on another form field). What is the expected result? The generated password should be masked. What happens instead? The generated password is not masked. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99b5d0a57fa8997a889e9b99db745b21aa06570d commit 99b5d0a57fa8997a889e9b99db745b21aa06570d Author: Ioana Pandele <ioanap@chromium.org> Date: Fri Nov 09 14:17:24 2018 Keep generated password unmasked until complete deletion Deleting characters from a generated password until only 3 or fewer characters are left, results in the password not counting as generated anymore. Until now, the leftover characters were masked immediately after the password length was shorter than 4 chars. This CL changes the behavior to keep the password unmasked until the user completely deletes it or it loses focus. Bug: 874822, 899798 Change-Id: I19a4116374388d51a5d5bafcba6d45076dde2800 Reviewed-on: https://chromium-review.googlesource.com/c/1305555 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605373}(cherry picked from commit 0c36cd0e46b0379f2918d5d2cfca4e479de25e89) Reviewed-on: https://chromium-review.googlesource.com/c/1329148 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#609} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/99b5d0a57fa8997a889e9b99db745b21aa06570d/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/99b5d0a57fa8997a889e9b99db745b21aa06570d/components/autofill/content/renderer/autofill_agent.cc [modify] https://crrev.com/99b5d0a57fa8997a889e9b99db745b21aa06570d/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/99b5d0a57fa8997a889e9b99db745b21aa06570d/components/autofill/content/renderer/password_generation_agent.h
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99b5d0a57fa8997a889e9b99db745b21aa06570d Commit: 99b5d0a57fa8997a889e9b99db745b21aa06570d Author: ioanap@chromium.org Commiter: ioanap@chromium.org Date: 2018-11-09 14:17:24 +0000 UTC Keep generated password unmasked until complete deletion Deleting characters from a generated password until only 3 or fewer characters are left, results in the password not counting as generated anymore. Until now, the leftover characters were masked immediately after the password length was shorter than 4 chars. This CL changes the behavior to keep the password unmasked until the user completely deletes it or it loses focus. Bug: 874822, 899798 Change-Id: I19a4116374388d51a5d5bafcba6d45076dde2800 Reviewed-on: https://chromium-review.googlesource.com/c/1305555 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605373}(cherry picked from commit 0c36cd0e46b0379f2918d5d2cfca4e479de25e89) Reviewed-on: https://chromium-review.googlesource.com/c/1329148 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#609} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 5