New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899791 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS][Unity] Needs to update Google services settings item only when modified

Project Member Reported by jlebel@chromium.org, Oct 29

Issue description

When the user taps a sync data item, before updating the settings modified by the user, |personalizedSectionBeingAnimated| is set to YES. This is to avoid to reload the UI while receiving the changed notification. Reloading the UI right after the user taps makes the switch animation not smooth.
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm?l=140

This simple mechanism fails when one setting modifies 2 settings. The section has to be reloaded to the second setting item is updated.
For example "auto complete wallet" item needs to be reloaded when the autofill item is changed. This is the same for the "activity and interactions" item and history item.

To solve that issue, I should build up the list of items to be reloaded when each section is updated:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm?sq=package:chromium&g=0&l=639

 
Status: WontFix (was: Assigned)
Deprecated with the new Unity.

Sign in to add a comment