New issue
Advanced search Search tips

Issue 899789 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
WebRTC-1.0-Spec-Compliance


Sign in to add a comment

Support applyConstraints for remote tracks

Project Member Reported by guidou@chromium.org, Oct 29

Issue description

Currently not supported.
 
Components: -Blink>GetUserMedia Blink>MediaStream
Owner: marinaciocea@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3136103101141dfa259ae64294e18e46727ba01

commit c3136103101141dfa259ae64294e18e46727ba01
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Dec 21 22:19:26 2018

Apply constraints for remote video tracks.

Bug:  899789 
Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f
Reviewed-on: https://chromium-review.googlesource.com/c/1388436
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618630}
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/content/renderer/media/stream/video_track_adapter.h
[add] https://crrev.com/c3136103101141dfa259ae64294e18e46727ba01/third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e2e36f0d46869b499d208e52a9de6c66c17b27

commit 20e2e36f0d46869b499d208e52a9de6c66c17b27
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Dec 22 00:15:53 2018

Revert "Apply constraints for remote video tracks."

This reverts commit c3136103101141dfa259ae64294e18e46727ba01.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 618630 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzMxMzYxMDMxMDExNDFkZmEyNTlhZTY0Mjk0ZTE4ZTQ2NzI3YmEwMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/27794

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html

Original change's description:
> Apply constraints for remote video tracks.
> 
> Bug:  899789 
> Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f
> Reviewed-on: https://chromium-review.googlesource.com/c/1388436
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618630}

Change-Id: I16a38cb267e3c18f636098bec9f8c58dcd951a59
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  899789 ,  917541 
Reviewed-on: https://chromium-review.googlesource.com/c/1389438
Cr-Commit-Position: refs/heads/master@{#618686}
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/video_track_adapter.h
[delete] https://crrev.com/3783894ab6b33d5112d834e43e8c06ad93a2dc09/third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8628b70ba9567521a1ff8b14c41c2f2c94679989

commit 8628b70ba9567521a1ff8b14c41c2f2c94679989
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Sat Dec 22 06:50:10 2018

Reland "Apply constraints for remote video tracks."

This is a reland of c3136103101141dfa259ae64294e18e46727ba01

Original change's description:
> Apply constraints for remote video tracks.
>
> Bug:  899789 
> Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f
> Reviewed-on: https://chromium-review.googlesource.com/c/1388436
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618630}

TBR = guidou, hbos

Bug:  899789 
Change-Id: I8e604e04c393b5ffdecaa1496778f076073b3a3e
Reviewed-on: https://chromium-review.googlesource.com/c/1389696
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618735}
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/8628b70ba9567521a1ff8b14c41c2f2c94679989/content/renderer/media/stream/video_track_adapter.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa087130e4e5f437858b5dc005e8e6ac3d679f4

commit 4fa087130e4e5f437858b5dc005e8e6ac3d679f4
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Mon Jan 14 15:34:41 2019

Add WPT for applyConstraints() for remote video tracks.

Bug:  899789 
Change-Id: If7e01be191d8b01f630b69a5f25c2f0929b617fd
Reviewed-on: https://chromium-review.googlesource.com/c/1409199
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622462}
[add] https://crrev.com/4fa087130e4e5f437858b5dc005e8e6ac3d679f4/third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-applyConstraints-remoteVideoTrack.html

Status: Fixed (was: Started)

Sign in to add a comment