New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899786 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Paygen failing on ToT M72

Project Member Reported by ahass...@chromium.org, Oct 29

Issue description

paygens are failing with:
08:18:47: ERROR: <class 'chromite.lib.cros_build_lib.RunCommandError'>: return code: 1; command: cros_sdk -- check_update_payload /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed --check --type full --disabled_tests move-same-src-dst-block --part_names kernel root --dst_part_paths /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_kernel.dat /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_root.dat --meta-sig /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed.metadata-signature --metadata-size 49666
Error: metadata signature: signed hash (zEYYM8rG6iygwYiKGBBcOajDicdzNj5JT+Om8APegs4=) different from actual (yLSsfIACoVkHYhyXArf1yr0PAFZKItxhEcRlfp46eiU=).

cmd=['cros_sdk', '--', 'check_update_payload', '/tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed', '--check', '--type', 'full', '--disabled_tests', 'move-same-src-dst-block', '--part_names', 'kernel', 'root', '--dst_part_paths', '/tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_kernel.dat', '/tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_root.dat', '--meta-sig', '/tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed.metadata-signature', '--metadata-size', '49666']
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/parallel.py", line 602, in TaskRunner
    task(*x, **task_kwargs)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/parallel.py", line 800, in <lambda>
    fn = lambda idx, task_args: out_queue.put((idx, task(*task_args)))
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/paygen/paygen_build_lib.py", line 239, in _GenerateSinglePayload
    dry_run=dry_run)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 734, in CreateAndUploadPayload
    dry_run=dry_run).Run()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 609, in Run
    self._VerifyPayload()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 582, in _VerifyPayload
    self._RunGeneratorCmd(cmd)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/paygen/paygen_payload_lib.py", line 140, in _RunGeneratorCmd
    combine_stdout_stderr=True)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/cros_build_lib.py", line 647, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 1; command: cros_sdk -- check_update_payload /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed --check --type full --disabled_tests move-same-src-dst-block --part_names kernel root --dst_part_paths /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_kernel.dat /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/new_root.dat --meta-sig /tmp/tmp.mONEBR7rE3/paygen_payload.DQffZW/delta.bin.signed.metadata-signature --metadata-size 49666
Error: metadata signature: signed hash (zEYYM8rG6iygwYiKGBBcOajDicdzNj5JT+Om8APegs4=) different from actual (yLSsfIACoVkHYhyXArf1yr0PAFZKItxhEcRlfp46eiU=).

probably checK_update_payload can't handle major version 2. I've tested this and it worked  in the past.

I'm going to revert https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1234822

to fix and reland later.
 
Thanks!
Cc: jdufault@chromium.org levarum@chromium.org ahass...@chromium.org athilenius@chromium.org martis@chromium.org
 Issue 899793  has been merged into this issue.
 Issue 895505  has been merged into this issue.
Cc: yixiang@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f182be28903fe35f4fffd3483b27ccdf1c0009f5

commit f182be28903fe35f4fffd3483b27ccdf1c0009f5
Author: Amin Hassani <ahassani@chromium.org>
Date: Mon Oct 29 21:18:55 2018

Revert "cros_generate_update_payload: Switch update_engine to major version 2"

This reverts commit 9201a4e1a9369d1618bc8737a97d9f6ded6d6e3e.

Reason for revert: < crbug.com/899786  - The paygen itself is working fine, but the update_payload_check failed>

Original change's description:
> cros_generate_update_payload: Switch update_engine to major version 2
>
> Per this change, we switch the update payload generation on the server side to
> major version 2. This new version includes smaller payloads (5%-10%) and has the
> capability to install multiple partitions (in comparison to a fixed two, kernel
> and root.) This affects all boards. For more information about the client
> support and the needed stepping stone refer to the attached issue.
>
> BUG= chromium:794404 
> TEST=cros flash
> TEST=paygen release builders tryjob
>
> Change-Id: I9e4cc9391fd0c5d5720e980f450882d9385c7061
> Reviewed-on: https://chromium-review.googlesource.com/1234822
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Amin Hassani <ahassani@chromium.org>
> Reviewed-by: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Sen Jiang <senj@chromium.org>

Bug:  chromium:899786 
Change-Id: I41c61c50f0fac921922007656f750bc2ee205f82
Reviewed-on: https://chromium-review.googlesource.com/c/1305356
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Trybot-Ready: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/f182be28903fe35f4fffd3483b27ccdf1c0009f5/scripts/cros_generate_update_payload.py
[modify] https://crrev.com/f182be28903fe35f4fffd3483b27ccdf1c0009f5/scripts/cros_generate_update_payload_unittest.py

Status: Fixed (was: Unconfirmed)

Sign in to add a comment