New issue
Advanced search Search tips

Issue 899784 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CQ posts passed dryrun comment 3 times on a CL

Project Member Reported by martiniss@chromium.org, Oct 29 
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1239574/12 is the CL. I ran CQ dry run, and CQ responded with the 'CL passed dry run' comment 3 times.

Not urgent, just mildly annoying.

Comment 1 by tandrii@chromium.org, Oct 30

Status: Available (was: Unconfirmed)
Oh, it's because CQ retried a 20s timeout when posting a comment 2 times.
The right thing to do is to check state of the change before retrying.

D  [pid:4686 tid:140656850958144 infra.libs.gerrit_api.gerrit_api:140] POST https://chromium-review.googlesource.com/a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review 
D  [pid:4686 tid:140656850958144 requests.packages.urllib3.util.retry:273] Incremented Retry for (url='/a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review'): Retry(total=3, connect=None, read=None, redirect=None) 
W  [pid:4686 tid:140656850958144 requests.packages.urllib3.connectionpool:580] Retrying (Retry(total=3, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='chromium-review.googlesource.com', port=443): Read timed out. (read timeout=20.0)",)': /a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review 
D  [pid:4686 tid:140656850958144 requests.packages.urllib3.util.retry:273] Incremented Retry for (url='/a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review'): Retry(total=2, connect=None, read=None, redirect=None) 
W  [pid:4686 tid:140656850958144 requests.packages.urllib3.connectionpool:580] Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='chromium-review.googlesource.com', port=443): Read timed out. (read timeout=20.0)",)': /a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review 
D  [pid:4686 tid:140656850958144 requests.packages.urllib3.util.retry:273] Incremented Retry for (url='/a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review'): Retry(total=1, connect=None, read=None, redirect=None) 
W  [pid:4686 tid:140656850958144 requests.packages.urllib3.connectionpool:580] Retrying (Retry(total=1, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='chromium-review.googlesource.com', port=443): Read timed out. (read timeout=20.0)",)': /a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review 
D  [pid:4686 tid:140656850958144 requests.packages.urllib3.connectionpool:364] "POST /a/changes/1239574/revisions/70e2d3ba7709b1d0b26fc994b35b9ce3526b8c3e/review HTTP/1.1" 200 8
►

Sign in to add a comment