Flaky test: PersonalDataManagerTest.UpdateClientValidityStates_Version Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/45704 Test output log: https://chromium-swarm.appspot.com/task?id=40d9854440b00910 Culprit (100.0% confidence): r603488 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKRAWNocm9taXVtLm1lbW9yeS9NYWMgQVNhbiA2NCBUZXN0cyAoMSkvNDU3MDQvY29tcG9uZW50c191bml0dGVzdHMvVUdWeWMyOXVZV3hFWVhSaFRXRnVZV2RsY2xSbGMzUXVWWEJrWVhSbFEyeHBaVzUwVm1Gc2FXUnBkSGxUZEdGMFpYTmZWbVZ5YzJsdmJnPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PersonalDataManagerTest.UpdateClientValidityStates_Version&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKRAWNocm9taXVtLm1lbW9yeS9NYWMgQVNhbiA2NCBUZXN0cyAoMSkvNDU3MDQvY29tcG9uZW50c191bml0dGVzdHMvVUdWeWMyOXVZV3hFWVhSaFRXRnVZV2RsY2xSbGMzUXVWWEJrWVhSbFEyeHBaVzUwVm1Gc2FXUnBkSGxUZEdGMFpYTmZWbVZ5YzJsdmJnPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Parastoo, could you please take a look?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c915c4c1cdda7380df9205180ac240e242e767c commit 0c915c4c1cdda7380df9205180ac240e242e767c Author: Parastoo Geranmayeh <parastoog@google.com> Date: Fri Nov 02 15:26:54 2018 [AF] Validate profiles for each major version Update the profiles' validities for each major version to keep up with the possible changes in the Autofill Profile Validator logic. See: go/autofill-use-validation Bug: 899783 Change-Id: Ie1c52df4c13a5579eb5265bda1eea19d02c5b123 Reviewed-on: https://chromium-review.googlesource.com/c/1311085 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#604927} [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/browser/autofill_profile.h [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/common/autofill_prefs.cc [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/autofill/core/common/autofill_prefs.h [modify] https://crrev.com/0c915c4c1cdda7380df9205180ac240e242e767c/components/browser_sync/profile_sync_service_autofill_unittest.cc
Comment 1 by dtapu...@chromium.org
, Oct 29