New issue
Advanced search Search tips

Issue 899781 link

Starred by 1 user
Status: Fixed
Owner:
danyao@chromium.org
Closed: Nov 14
Cc:
eugene...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Refactor -[CRWWebController webView:didFinishNavigation] and DCHECK invariants early

Project Member Reported by danyao@chromium.org, Oct 29 
Summary of action item:

- Refactor -[CRWWebController webView:didFinishNavigation] to separate SlimNavigationManager code and kWebErrorPage code.
- DCHECK invariant violations earlier.
- Add nullptr check for all dereferences of |item| and |context|, which may be null even though they should not.

Comment 2 by danyao@chromium.org, Nov 14

Status: Fixed (was: Accepted)
This is done in https://chromium-review.googlesource.com/c/chromium/src/+/1303050.
►

Sign in to add a comment