There are some login/lock tests which still use the webui lock/login screen which are valuable. We should migrate them to use views.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56861a66af074a5e3004acf246b0ba3374f81353 commit 56861a66af074a5e3004acf246b0ba3374f81353 Author: Jacob Dufault <jdufault@google.com> Date: Mon Nov 05 21:53:50 2018 cros: Remove some unused ScreenLockerTester methods TBR=dtseng@chromium.org Bug: 899777 Change-Id: I2301630944dbd19198a9d09d4030dde2ddacb587 Reviewed-on: https://chromium-review.googlesource.com/c/1303051 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#605482} [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/chromeos/login/lock/screen_locker_tester.h [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/56861a66af074a5e3004acf246b0ba3374f81353/chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125 commit bf83cf6fc9186b6bdf34bc91524d1bebbfde2125 Author: Jacob Dufault <jdufault@google.com> Date: Thu Nov 15 17:31:22 2018 cros: More cleanup on ScreenLockerTester TBR=dtseng@chromium.org Bug: 899777 Change-Id: Id56ad8bb68c95b4412fbc9ebacef7921216fe9ce Reviewed-on: https://chromium-review.googlesource.com/c/1317924 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608415} [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/screen_locker.h [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/screen_locker_tester.h [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/login/lock/webui_screen_locker.h [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/bf83cf6fc9186b6bdf34bc91524d1bebbfde2125/chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec9eead7621baac412190e6ae33015e7c54b5aa8 commit ec9eead7621baac412190e6ae33015e7c54b5aa8 Author: Jacob Dufault <jdufault@google.com> Date: Fri Nov 16 22:24:47 2018 cros: Add views-lock test mojo api and add an interactive ui test for it Validate that we can show the lock screen, enter a bad password, and then enter a good password. Bug: 899777 Change-Id: Ie3c8ff629524374362db5fe51f648defdf5331dc Reviewed-on: https://chromium-review.googlesource.com/c/1323701 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608990} [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/BUILD.gn [add] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/login/login_screen_test_api.cc [add] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/login/login_screen_test_api.h [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/login/ui/login_password_view.cc [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/login/ui/login_password_view.h [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/manifest.json [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/mojo_test_interface_factory.cc [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/public/interfaces/BUILD.gn [add] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/ash/public/interfaces/login_screen_test_api.mojom [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/ec9eead7621baac412190e6ae33015e7c54b5aa8/chrome/browser/chromeos/login/lock/screen_locker_tester.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e27167a86f38a3f2f438c125e0f0847e18674b99 commit e27167a86f38a3f2f438c125e0f0847e18674b99 Author: Jacob Dufault <jdufault@google.com> Date: Tue Nov 20 22:08:38 2018 cros: Move ScreenLocker tests from interactive_ui_test to browser_test - Remove the webui lock screen tests. - Re-enable flaky test since it should no longer flake because there is no longer webui involved. Bug: 899777 Change-Id: I759ad6d20a08ad48e6a992fcfca9a25572ad16a5 Reviewed-on: https://chromium-review.googlesource.com/c/1327163 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609819} [modify] https://crrev.com/e27167a86f38a3f2f438c125e0f0847e18674b99/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/e27167a86f38a3f2f438c125e0f0847e18674b99/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92925c667f1644dc64e031a120b11c3d86eb3cc6 commit 92925c667f1644dc64e031a120b11c3d86eb3cc6 Author: Jacob Dufault <jdufault@google.com> Date: Thu Nov 29 22:00:56 2018 cros: Remove WizardInProcessBrowserTest The base class convoluted the inheritance structure and it is simpler to directly derive from InProcessBrowserTest. Bug: 899777 Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 Reviewed-on: https://chromium-review.googlesource.com/c/1345244 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612394} [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [delete] https://crrev.com/180186cf733169ab3631d50ad996c585a98e60cc/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1a3ae3dcd88c317162104461c91dfc362a96dc5 commit b1a3ae3dcd88c317162104461c91dfc362a96dc5 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Nov 30 02:24:09 2018 Revert "cros: Remove WizardInProcessBrowserTest" This reverts commit 92925c667f1644dc64e031a120b11c3d86eb3cc6. Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 rowserTestBase received signal: Terminated. Backtrace: #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7feafb349cb0 <unknown> #4 0x7feafb4116d3 epoll_wait #5 0x7feb2e96353f epoll_dispatch #6 0x7feb2e956cc5 event_base_loop #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() #9 0x7feb2e6eb322 base::RunLoop::Run() #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() Original change's description: > cros: Remove WizardInProcessBrowserTest > > The base class convoluted the inheritance structure and it is simpler to > directly derive from InProcessBrowserTest. > > Bug: 899777 > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612394} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1356168 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612523} [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [add] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/b1a3ae3dcd88c317162104461c91dfc362a96dc5/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/568482011304888ca0042b23223724c42691da6b commit 568482011304888ca0042b23223724c42691da6b Author: Jacob Dufault <jdufault@chromium.org> Date: Mon Dec 03 21:07:49 2018 Reland "cros: Remove WizardInProcessBrowserTest" Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) Original change's description: > Revert "cros: Remove WizardInProcessBrowserTest" > > This reverts commit 92925c667f1644dc64e031a120b11c3d86eb3cc6. > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > rowserTestBase received signal: Terminated. Backtrace: > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7feafb349cb0 <unknown> > #4 0x7feafb4116d3 epoll_wait > #5 0x7feb2e96353f epoll_dispatch > #6 0x7feb2e956cc5 event_base_loop > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > #9 0x7feb2e6eb322 base::RunLoop::Run() > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > Original change's description: > > cros: Remove WizardInProcessBrowserTest > > > > The base class convoluted the inheritance structure and it is simpler to > > directly derive from InProcessBrowserTest. > > > > Bug: 899777 > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612394} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899777 > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612523} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899777 Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 Reviewed-on: https://chromium-review.googlesource.com/c/1359135 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613244} [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [delete] https://crrev.com/dd0f0eac96fa507606d151fbba0abf926ed775fe/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/568482011304888ca0042b23223724c42691da6b/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88fb7f25e8625d898ccdb40f709e04c7897b6e81 commit 88fb7f25e8625d898ccdb40f709e04c7897b6e81 Author: Jacob Dufault <jdufault@google.com> Date: Mon Dec 03 23:39:10 2018 cros: Make ScreenLockerTester have a higher-level synchronous API that handles waiting - Simplify helper code used with ScreenLockerTest.TestFullscreenExit - Simplify BrailleDisplayPrivateAPIUnitTest.KeyEventOnLockScreen, remove MSAN restriction since views-lock screen is significantly faster to load Bug: 899777 Change-Id: I0cf3c50c562289c42513b8509a86f901caf93035 Reviewed-on: https://chromium-review.googlesource.com/c/1327543 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#613321} [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/chromeos/login/lock/screen_locker_tester.h [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/88fb7f25e8625d898ccdb40f709e04c7897b6e81/chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77b5336f611f0643bfbe84320535c2b030c7e7d4 commit 77b5336f611f0643bfbe84320535c2b030c7e7d4 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Tue Dec 04 00:51:35 2018 Revert "Reland "cros: Remove WizardInProcessBrowserTest"" This reverts commit 568482011304888ca0042b23223724c42691da6b. Reason for revert: WizardControllerDeviceStateTest.ControlFlowDeviceDisabled timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9330 Original change's description: > Reland "cros: Remove WizardInProcessBrowserTest" > > Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) > > Original change's description: > > Revert "cros: Remove WizardInProcessBrowserTest" > > > > This reverts commit 92925c667f1644dc64e031a120b11c3d86eb3cc6. > > > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > > > rowserTestBase received signal: Terminated. Backtrace: > > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > > #3 0x7feafb349cb0 <unknown> > > #4 0x7feafb4116d3 epoll_wait > > #5 0x7feb2e96353f epoll_dispatch > > #6 0x7feb2e956cc5 event_base_loop > > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > > #9 0x7feb2e6eb322 base::RunLoop::Run() > > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > > > Original change's description: > > > cros: Remove WizardInProcessBrowserTest > > > > > > The base class convoluted the inheritance structure and it is simpler to > > > directly derive from InProcessBrowserTest. > > > > > > Bug: 899777 > > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#612394} > > > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 899777 > > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612523} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 899777 > Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 > Reviewed-on: https://chromium-review.googlesource.com/c/1359135 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613244} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org Change-Id: Ifeec16d8f954fd9a9aede38a2fa0bffcc107dab4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1359815 Reviewed-by: Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#613359} [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [add] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/77b5336f611f0643bfbe84320535c2b030c7e7d4/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c19880775b223830ee39f172e2b9fc3fb7039e1f commit c19880775b223830ee39f172e2b9fc3fb7039e1f Author: Jacob Dufault <jdufault@google.com> Date: Wed Dec 05 17:39:33 2018 Reland cros: Remove WizardInProcessBrowserTest This relands https://chromium-review.googlesource.com/c/chromium/src/+/1359815. WizardControllerTest now appends --login-manager to the command line, which should fix the flake in the previous CL. TBR=xiyuan@chromium.org TBR=emaxx@chromium.org Bug: 899777 Change-Id: I0c9b85d0214f3f4e3222028356a5e70fb797a7b5 Reviewed-on: https://chromium-review.googlesource.com/c/1361797 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#614009} [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [delete] https://crrev.com/56cf544dc9cf61bc646d3d5382fb57638f9aa5a2/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/c19880775b223830ee39f172e2b9fc3fb7039e1f/chrome/test/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Nov 5