New issue
Advanced search Search tips

Issue 899775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

cleaned up interrupted download may not remove the downloaded file

Project Member Reported by qin...@chromium.org, Oct 29

Issue description

if a download is interrupted with non-resumable reasons, we don't clean up the file properly when removing it from history.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cd8209a61aca1283f04b970e3549d36e9cbcc49

commit 1cd8209a61aca1283f04b970e3549d36e9cbcc49
Author: Min Qin <qinmin@chromium.org>
Date: Fri Nov 02 20:54:52 2018

Remove non-resumable interrupted file from disk

On Android, we clean up non-resumable interrupted file from the history and
download db. However, the actual files may still be on disk.
This CL removes those files while cleaning up the database.

BUG= 899775 

Change-Id: I59bdf32c11789448295126b2819d326fedcf54ff
Reviewed-on: https://chromium-review.googlesource.com/c/1310499
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605047}
[modify] https://crrev.com/1cd8209a61aca1283f04b970e3549d36e9cbcc49/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/1cd8209a61aca1283f04b970e3549d36e9cbcc49/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/1cd8209a61aca1283f04b970e3549d36e9cbcc49/components/download/public/common/download_utils.h
[modify] https://crrev.com/1cd8209a61aca1283f04b970e3549d36e9cbcc49/content/browser/download/download_manager_impl.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment