Setup dialog buttons cut off in tablet mode on 1.25x+ scale factor |
||||
Issue descriptionIt looks like if we launch the setup flow in tablet mode on devices with a scaled up screen density (ctrl-shift-+), the buttons to continue/cancel setup are cut off of the bottom of the screen with no way to get to them. Ryan, assigning to you since you did some of the original tablet mode and windowing work. Original report from erikkay@: I got the better together promo popup window. However, the window was strangely clipped, so I couldn't initially get to the button to say I wanted to turn it on. Scrolling or selecting text (my normal workaround for things that break like this) didn't work, and the window was missing a maximize button, so I couldn't make it bigger directly. I eventually worked around this by using the alt-] maximize shortcut. Unfortunately, I didn't capture a bug report or screenshot with this (apologies, that's why I'm guessing by direct filing in this component). Here are my two guesses for possible causes: - my default scale factor is 125% - I have a large external monitor plugged in
,
Oct 30
FYI, I'm not sure if the below UMA report is accurate, but assuming it is, it looks like ~2M users have their scale factor set to +/- 10% https://uma.googleplex.com/p/chrome/histograms/?endDate=20181028&dayCount=28&histograms=DisplayManager.InternalDisplayZoomPercentage&fixupData=true&showMax=true&filters=platform%2Ceq%2CC%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
,
Oct 30
Yes if the user Page Zoom to larger UI, we should show scroll bar. Here is the spec for scroll bar: https://drive.google.com/open?id=0B6x6iYCtKinEbVBwQVNtN2tWTXc
,
Oct 30
Thanks!
,
Oct 31
Is there a way to know if the UI will be in this state? If so, do we have control over how the setup modal is focussed ie. the user at least is able to see the title and can then scroll to view the buttons and the rest of the text?
,
Nov 14
Investigating.
,
Nov 20
Apologies for the delayed response. The fix looks quite trivial. I have a draft fix at [1]. I've attached a screenshot of the result (the scrollbars are visible because I was actively touching the screen). This works as expected in both tablet and clamshell mode. We should probably land this initial fix now -- if there are any concerns about how it looks, that can be addressed in follow up CL. 1) https://chromium-review.googlesource.com/c/chromium/src/+/1343191
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cecfe61811dcc3ae80fda771a6026e13627ac31 commit 7cecfe61811dcc3ae80fda771a6026e13627ac31 Author: Ryan Hansberry <hansberry@chromium.org> Date: Tue Nov 27 21:11:03 2018 [CrOS MultiDevice] Allow overflow scrolling in setup dialog. Allowing overflow scrolling lets users with high page zoom settings scroll across and down overflowing content. Bug: 899774 Change-Id: I9bb6a8ea622b61c1d7b76d3cadb0f9be694fe4d3 Reviewed-on: https://chromium-review.googlesource.com/c/1343191 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#611321} [modify] https://crrev.com/7cecfe61811dcc3ae80fda771a6026e13627ac31/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_dialog.html
,
Nov 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jlklein@chromium.org
, Oct 301.8 MB
1.8 MB View Download