New issue
Advanced search Search tips

Issue 899770 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Wilco: add a top-level dependency on the diagnostics package

Project Member Reported by pmoy@chromium.org, Oct 29

Issue description

The diagnostics/telemetry daemon under development (see https://bugs.chromium.org/p/chromium/issues/detail?id=869377) is not currently included in build_packages for Wilco.

target-chromium-os-1.ebuild should include the dependency for the diagnostics package behind a USE flag. When build_packages --board=sarien and the build_image are run, the resulting image, when flashed to a sarien board, should have the diagnostics package installed. An easy check to see whether or not the diagnostics package is installed is to look for /etc/init/diagnosticsd.conf - if present, the diagnostics package was installed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5903a8214d01ff4e3984107fa114d6bf859c79bd

commit 5903a8214d01ff4e3984107fa114d6bf859c79bd
Author: Paul Moy <pmoy@chromium.org>
Date: Tue Oct 30 04:19:58 2018

overlay-sarien: Add the diagnostics USE flag

Add the USE flag for diagnostics, so the diagnosticsd
and diagnostics_processor daemons are included in the
image.

BUG= chromium:899770 
TEST=build_packages --board=sarien, check for
chromeos-base/diagnostics

Change-Id: I975ec7dfbd3e737fdc8fe41be879c32ab19087e4
Signed-off-by: Paul Moy <pmoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1305535
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/5903a8214d01ff4e3984107fa114d6bf859c79bd/overlay-sarien/profiles/base/make.defaults

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7625de1deead7622d0b715f817a58ebaa3748b8f

commit 7625de1deead7622d0b715f817a58ebaa3748b8f
Author: Paul Moy <pmoy@chromium.org>
Date: Tue Oct 30 19:03:25 2018

target-chromium-os: Build diagnostics when USE flag is enabled

Add a USE flag to optionally pull the platform2/diagnostics package
into the build.

BUG= chromium:899770 
TEST=USE="diagnostics" build_packages --board=sarien
ls /build/sarien/etc/init/ and check for diagnosticsd.conf and
diagnostics_processor.conf

Change-Id: Idc1a4970be209b3c75666f6d2c829bbc2205c7b1
Signed-off-by: Paul Moy <pmoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1305357
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>

[rename] https://crrev.com/7625de1deead7622d0b715f817a58ebaa3748b8f/virtual/target-chromium-os/target-chromium-os-1-r111.ebuild
[modify] https://crrev.com/7625de1deead7622d0b715f817a58ebaa3748b8f/virtual/target-chromium-os/target-chromium-os-1.ebuild

Status: Verified (was: Untriaged)

Sign in to add a comment