Tidy up beeping and debug messages in vboot |
||
Issue descriptionAt present we beep when errors are detected or something is not allowed. Recent worked unified the beeping options in vb2_error_beep(): https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1292246 We rely on the caller to print a debug message which is appropriate for the beep. We should see if we can tidy this up. One idea: Pass the VB2_DEBUG() and VbExDisplayDebugInfo() strings to vb2_error_beep().
,
Nov 6
Try with this one first: https://cs.corp.google.com/chromeos_public/src/platform/vboot_reference/firmware/lib/vboot_ui.c?rcl=f067d5a14dde459432940a1e519eacdb75282281&l=97 cros_workon-grunt start vboot_reference FEATURES=test emerge-grunt vboot_reference
,
Nov 6
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0 commit f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0 Author: Nick Crews <ncrews@google.com> Date: Fri Dec 14 03:27:59 2018 vboot_reference: Merge error beeping, printing, and logging Added a vb2_error_notify() function that bundles a log message, screen notification message, beep, and flash into one function, since callers were often calling these three things separately. BUG=chromium:899762 TEST=Image still builds and runs on an Aleena, function works on at least one of the calls, the others are harder to test. TEST=make runtests BRANCH=none Change-Id: I82224f8ffa1c326c5e7293a2c00db4dc5d80bf3a Reviewed-on: https://chromium-review.googlesource.com/1330013 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Eugene Hermann <yherman@google.com> Reviewed-by: Nick Crews <ncrews@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> [modify] https://crrev.com/f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0/firmware/lib/vboot_ui_common.c [modify] https://crrev.com/f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0/firmware/lib/vboot_ui_menu.c [modify] https://crrev.com/f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0/firmware/lib/include/vboot_ui_common.h [modify] https://crrev.com/f07ea5490bab8a2972e3b6d77ac67ca7cbf5cad0/firmware/lib/vboot_ui.c |
||
►
Sign in to add a comment |
||
Comment 1 by sjg@google.com
, Nov 6