New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Task



Sign in to add a comment

Rename image-related policies for consistency

Project Member Reported by cha...@chromium.org, Oct 29

Issue description

The set of image-related policies are currently named as:
image-compression
max-downscaling-image
unsized-media
legacy-image-formats

The naming is inconsistent although the policies are pretty closely related.

These policies are related to best practices, specifically detecting the bad practice. For best practice policies, the general idea is to name the policy-controlled feature as <bad thing to stop doing>, so that disabling the feature turns off the bad practice.

As well, there are existing Lighthouse audits for some of these practices, so it would be nice to align with that existing guidance.

Propose renaming the policies as follows:
- "image-compression" -> "unoptimized-images" (see https://developers.google.com/web/tools/lighthouse/audits/unoptimized-images)
- "max-downscaling-image" -> "oversized-images" (see https://developers.google.com/web/tools/lighthouse/audits/oversized-images)

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6

commit f91910eba0d6f1d81dc2ec39255b5ad348b39dc6
Author: Luna Lu <loonybear@chromium.org>
Date: Mon Nov 05 16:57:10 2018

Rename Image Policies

This CL renames the following feature policy features:
image-compression > unoptimized-images
max-downscaling-image > oversized-images

Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745

BUG:  899761 ,  889185 
Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745
Reviewed-on: https://chromium-review.googlesource.com/c/1308533
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605360}
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-compression-cached-image-expected.png
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-compression-cached-image.html
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-unoptimized-images-cached-image.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-unoptimized-images.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-edge-cases.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-resize.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-responsive-image.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-edge-cases.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-forced-layout.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-resize.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-responsive-image.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-styles.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-responsive-images-expected.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-edge-cases.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-forced-layout.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-resize.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-responsive-images.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-styles.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/feature_policy/feature_policy.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment