New issue
Advanced search Search tips

Issue 899758 link

Starred by 1 user
Status: Started
Owner:
hidehiko@chromium.org
Cc:
derat@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Port session manager related CQ autotests into tast.

Project Member Reported by hidehiko@chromium.org, Oct 29 
This is tracking issue. Here is the list of candidates:

login_GuestAndActualSession
login_LogoutProcessCleanup
login_MultiUserPolicy
login_OwnershipApi
login_OwnershipNotRetaken
login_OwnershipRetaken
login_OwnershipTaken
login_RemoteOwnership
login_RetrieveActiveSessions
login_SameSessionTwice
login_UserPolicyKeys
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/82efb36eedf591a6e00242fcd1cb1b1a87f1a4a7

commit 82efb36eedf591a6e00242fcd1cb1b1a87f1a4a7
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Nov 16 13:02:21 2018

Fix sysroot error.

If sysroot is "/", i.e. host build, some packages won't build.
This CL fixes the problem.

BUG=chromium:899758
TEST=Build.

Change-Id: I4b11e13bd42d158b515581c5ca9d8037ebf70732
Reviewed-on: https://chromium-review.googlesource.com/1331308
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/82efb36eedf591a6e00242fcd1cb1b1a87f1a4a7/common-mk/BUILDCONFIG.gn
[modify] https://crrev.com/82efb36eedf591a6e00242fcd1cb1b1a87f1a4a7/shill/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aa64658c2ffa16d01d26ecd829ff297caf068374

commit aa64658c2ffa16d01d26ecd829ff297caf068374
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Nov 30 00:09:01 2018

Add policy Go proto package.

BUG=chromium:899758
TEST=Build.
CQ-DEPEND=CL:1331309

Change-Id: Ie2e9cdceebe9d84156225d26820358f3a5dd2c4a
Reviewed-on: https://chromium-review.googlesource.com/1331275
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/aa64658c2ffa16d01d26ecd829ff297caf068374/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[add] https://crrev.com/aa64658c2ffa16d01d26ecd829ff297caf068374/chromeos-base/policy-go-proto/policy-go-proto-9999.ebuild
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7191401ad4e554f61cb49c19641bcf9f205a732f

commit 7191401ad4e554f61cb49c19641bcf9f205a732f
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Nov 30 00:09:01 2018

policy_proto: Add policy package.

To build policy related proto files into go.
proto_library with "gen_go = true" did not work, and nobody uses it.

Introduced goproto_library template, rather than fixing gen_go,
because the template pattern is so different from the existing one
and cannot share most of parts, unfortunately.

BUG=chromium:899758
TEST=Build.

Change-Id: I12d5afbf2994ad6d2e0278f8be0b74f3c19c28a0
Reviewed-on: https://chromium-review.googlesource.com/1331309
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[add] https://crrev.com/7191401ad4e554f61cb49c19641bcf9f205a732f/policy_proto/BUILD.gn
[modify] https://crrev.com/7191401ad4e554f61cb49c19641bcf9f205a732f/common-mk/external_dependencies/BUILD.gn
[modify] https://crrev.com/7191401ad4e554f61cb49c19641bcf9f205a732f/common-mk/proto_library.gni
[modify] https://crrev.com/7191401ad4e554f61cb49c19641bcf9f205a732f/README.md
[add] https://crrev.com/7191401ad4e554f61cb49c19641bcf9f205a732f/policy_proto/README.md
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/738a19bfa72008b8bb3f43608fb73acfb6d4aa5e

commit 738a19bfa72008b8bb3f43608fb73acfb6d4aa5e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Dec 04 00:41:02 2018

tast-tests: Add package dependency.

go-cmp and crypto are newly used in session.OwnershipAPI test.

BUG=chromium:899758
TEST=Built locally.

Change-Id: I279d029c80793fc7c1bdd641c654561acca6b080
Reviewed-on: https://chromium-review.googlesource.com/1356925
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/738a19bfa72008b8bb3f43608fb73acfb6d4aa5e/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/77013773c04b9a7a43c5929cd9ac64515bdcca6d

commit 77013773c04b9a7a43c5929cd9ac64515bdcca6d
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Dec 13 01:04:44 2018

tast-tests: Port login_OwnershipNotRetaken.

BUG=chromium:899758
TEST=Ran on DUT locally.

Change-Id: I0eeec73b91b244f7ea07af9aa1c1ac86cb03f3e9
Reviewed-on: https://chromium-review.googlesource.com/1351970
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[add] https://crrev.com/77013773c04b9a7a43c5929cd9ac64515bdcca6d/src/chromiumos/tast/local/bundles/cros/session/ownership_not_retaken.go
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/8e14bb108baa135703f6f455bdd9d0e20f09b8bf

commit 8e14bb108baa135703f6f455bdd9d0e20f09b8bf
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Jan 02 21:29:02 2019

tast-tests: Introduce session.RejectDuplicate.

This is ported from login_SameSessionTwice.

BUG=chromium:899758
TEST=Ran locally.

Change-Id: I43df0bf285ac9322971ff1d4044c2bca9656fa33
Reviewed-on: https://chromium-review.googlesource.com/1387266
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[add] https://crrev.com/8e14bb108baa135703f6f455bdd9d0e20f09b8bf/src/chromiumos/tast/local/bundles/cros/session/reject_duplicate.go
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/3510306fdab4aff3275dfe3fb9f2ba901c132f44

commit 3510306fdab4aff3275dfe3fb9f2ba901c132f44
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Jan 02 21:28:58 2019

tast-tests: Watch "stopped" signal on Chrome logout.

This merges login_LoginSuccess test into ui.ChromeLogin.
The missing part in ui.ChromeLogin was observing "stopped",
so this adds it.

BUG=chromium:899758
TEST=Ran locally.

Change-Id: I15e770c713c5c0854520df7de9aacf9e291d8c98
Reviewed-on: https://chromium-review.googlesource.com/1387271
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/3510306fdab4aff3275dfe3fb9f2ba901c132f44/src/chromiumos/tast/local/bundles/cros/ui/chrome_login.go
►

Sign in to add a comment