Generation popup doesn't appear when deleting to 3 chars |
||
Issue descriptionChrome Version: 72.0.3590.0 (Dev) OS: Linux (only checked on Linux) What steps will reproduce the problem? (1) Navigate to imdb.com > Sign in > Create new account (2) Click on the new password field and generate a password. (3) Delete characters from the password until only 3 remain. What is the expected result? The generation popup offering a new generated password reappears. What happens instead? The generation popup offering a new generated password doesn't reappear until the next action on the field (e.g. deleting one more character or typing one).
,
Oct 29
This is a duplicate of Issue 850079 . The drop down is suppressed via AutofillAgent::TextFieldDidEndEditing path immediately after being shown. Thus, it's not a regression. Interestingly, I don't observe exactly the same behavior on my debug build. The editing dropdown is not visible while I'm removing the characters. Do you see it?
,
Oct 30
Good point. I don't see the editing dropdown while editing either.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6 commit acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Nov 09 16:18:47 2018 Ignore blur events caused by the password generation. When PasswordGenerationAgent copies the password value from the password field to "Confirm Password" filed, a blur event is generated. It hides the currently open generation prompt. Those events are just side-effects of how the class works and should be ignored. Bug: 899756 , 850079 Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444 Reviewed-on: https://chromium-review.googlesource.com/c/1327205 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#606863} [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/chrome/renderer/autofill/fake_password_manager_client.cc [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/chrome/renderer/autofill/fake_password_manager_client.h [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/components/autofill/content/renderer/autofill_agent.cc [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6/components/autofill/content/renderer/password_generation_agent.h
,
Nov 9
|
||
►
Sign in to add a comment |
||
Comment 1 by ioanap@chromium.org
, Oct 29